Re: [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST

2015-07-29 Thread Paolo Bonzini
On 29/07/2015 12:14, Marc-André Lureau wrote: > I don't mind, I guess I just wanted to have a similar dump as the > existing save(): > > if (ivshmem_has_feature(proxy, IVSHMEM_MSI)) { > msix_save(pci_dev, f); Ah, okay then. Paolo

Re: [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST

2015-07-29 Thread Marc-André Lureau
Hi On Wed, Jul 29, 2015 at 10:31 AM, Paolo Bonzini wrote: > I think what we've been doing (e.g. hw/scsi/megasas.c) is to just always > save it. I don't mind, I guess I just wanted to have a similar dump as the existing save(): if (ivshmem_has_feature(proxy, IVSHMEM_MSI)) { msix_save

Re: [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST

2015-07-29 Thread Paolo Bonzini
On 29/07/2015 10:28, Marc-André Lureau wrote: >> Why can't it be saved unconditionally? > > It can, it's just that in some case (msi=0) it's unused. I think what we've been doing (e.g. hw/scsi/megasas.c) is to just always save it. Paolo

Re: [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST

2015-07-29 Thread Marc-André Lureau
Hi On Wed, Jul 29, 2015 at 9:41 AM, Paolo Bonzini wrote: > Why can't it be saved unconditionally? It can, it's just that in some case (msi=0) it's unused. -- Marc-André Lureau

Re: [Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST

2015-07-29 Thread Paolo Bonzini
On 28/07/2015 02:32, Marc-André Lureau wrote: > From: Marc-André Lureau > > ivshmem is going to use MSIX state conditionally. > > Signed-off-by: Marc-André Lureau > --- > include/hw/pci/msix.h | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/include

[Qemu-devel] [PATCH v2 02/45] msix: add VMSTATE_MSIX_TEST

2015-07-27 Thread Marc-André Lureau
From: Marc-André Lureau ivshmem is going to use MSIX state conditionally. Signed-off-by: Marc-André Lureau --- include/hw/pci/msix.h | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h index 954d82b..72e5f93 100644