Re: [Qemu-devel] [PATCH v2 02/10] intel-iommu: remove IntelIOMMUNotifierNode

2018-05-17 Thread Auger Eric
Hi Peter, On 05/17/2018 12:02 PM, Peter Xu wrote: > On Thu, May 17, 2018 at 11:46:22AM +0200, Auger Eric wrote: >> Hi Peter, >> >> On 05/04/2018 05:08 AM, Peter Xu wrote: >>> That is not really necessary. Removing that node struct and put the >>> list entry directly into VTDAddressSpace. It simp

Re: [Qemu-devel] [PATCH v2 02/10] intel-iommu: remove IntelIOMMUNotifierNode

2018-05-17 Thread Peter Xu
On Thu, May 17, 2018 at 12:10:41PM +0200, Auger Eric wrote: > Hi Peter, > > On 05/17/2018 12:02 PM, Peter Xu wrote: > > On Thu, May 17, 2018 at 11:46:22AM +0200, Auger Eric wrote: > >> Hi Peter, > >> > >> On 05/04/2018 05:08 AM, Peter Xu wrote: > >>> That is not really necessary. Removing that no

Re: [Qemu-devel] [PATCH v2 02/10] intel-iommu: remove IntelIOMMUNotifierNode

2018-05-17 Thread Peter Xu
On Thu, May 17, 2018 at 11:46:22AM +0200, Auger Eric wrote: > Hi Peter, > > On 05/04/2018 05:08 AM, Peter Xu wrote: > > That is not really necessary. Removing that node struct and put the > > list entry directly into VTDAddressSpace. It simplfies the code a lot. > > > > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH v2 02/10] intel-iommu: remove IntelIOMMUNotifierNode

2018-05-17 Thread Auger Eric
Hi Peter, On 05/04/2018 05:08 AM, Peter Xu wrote: > That is not really necessary. Removing that node struct and put the > list entry directly into VTDAddressSpace. It simplfies the code a lot. > > Signed-off-by: Peter Xu > --- > include/hw/i386/intel_iommu.h | 9 ++-- > hw/i386/intel_iom

[Qemu-devel] [PATCH v2 02/10] intel-iommu: remove IntelIOMMUNotifierNode

2018-05-03 Thread Peter Xu
That is not really necessary. Removing that node struct and put the list entry directly into VTDAddressSpace. It simplfies the code a lot. Signed-off-by: Peter Xu --- include/hw/i386/intel_iommu.h | 9 ++-- hw/i386/intel_iommu.c | 41 ++- 2 files ch