Re: [Qemu-devel] [PATCH v2 01/29] include: Make headers more self-contained

2019-08-07 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> Alex Bennée writes: >> >>> Markus Armbruster writes: >>> Back in 2016, we discussed[1] rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We go

Re: [Qemu-devel] [PATCH v2 01/29] include: Make headers more self-contained

2019-08-07 Thread Alex Bennée
Markus Armbruster writes: > Alex Bennée writes: > >> Markus Armbruster writes: >> >>> Back in 2016, we discussed[1] rules for headers, and these were >>> generally liked: >>> >>> 1. Have a carefully curated header that's included everywhere first. We >>>got that already thanks to Peter:

Re: [Qemu-devel] [PATCH v2 01/29] include: Make headers more self-contained

2019-08-07 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> Back in 2016, we discussed[1] rules for headers, and these were >> generally liked: >> >> 1. Have a carefully curated header that's included everywhere first. We >>got that already thanks to Peter: osdep.h. >> >> 2. Headers should normall

Re: [Qemu-devel] [PATCH v2 01/29] include: Make headers more self-contained

2019-08-07 Thread Alex Bennée
Markus Armbruster writes: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers should normally include everything they need

[Qemu-devel] [PATCH v2 01/29] include: Make headers more self-contained

2019-08-06 Thread Markus Armbruster
Back in 2016, we discussed[1] rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h. 2. Headers should normally include everything they need beyond osdep.h. If exceptions are need