Re: [Qemu-devel] [PATCH v2 01/17] Openrisc: add target stubs

2012-05-29 Thread Jia Liu
Hi Andreas, On Sun, May 27, 2012 at 8:44 PM, Andreas Färber wrote: > Am 27.05.2012 07:32, schrieb Jia Liu: >> add openrisc target stubs. >> >> Signed-off-by: Jia Liu > > Minor nitpick: I'd recommend to stick to the typographic conventions > outlined here: > https://live.gnome.org/Git/CommitMessa

Re: [Qemu-devel] [PATCH v2 01/17] Openrisc: add target stubs

2012-05-27 Thread Andreas Färber
Am 27.05.2012 07:32, schrieb Jia Liu: > add openrisc target stubs. > > Signed-off-by: Jia Liu Minor nitpick: I'd recommend to stick to the typographic conventions outlined here: https://live.gnome.org/Git/CommitMessages In particular please start the sentence with a capital A. GNOME recommend a

[Qemu-devel] [PATCH v2 01/17] Openrisc: add target stubs

2012-05-26 Thread Jia Liu
add openrisc target stubs. Signed-off-by: Jia Liu --- Makefile.target |3 + arch_init.c |2 + arch_init.h |1 + configure| 10 ++- cpu-exec.c |2 + default-configs/or32-soft