Re: [Qemu-devel] [PATCH v2 01/12] qdev-monitor: print help to stdout

2018-09-07 Thread Marc-André Lureau
Hi On Fri, Sep 7, 2018 at 5:49 PM Eric Blake wrote: > > On 09/07/2018 02:59 AM, Marc-André Lureau wrote: > > qdev_device_help() is used from command line "-device help", or from > > HMP "device_add". If used from command line, print help to stdout > > (it is only printed on explicit demand). > >

Re: [Qemu-devel] [PATCH v2 01/12] qdev-monitor: print help to stdout

2018-09-07 Thread Eric Blake
On 09/07/2018 02:59 AM, Marc-André Lureau wrote: qdev_device_help() is used from command line "-device help", or from HMP "device_add". If used from command line, print help to stdout (it is only printed on explicit demand). Signed-off-by: Marc-André Lureau --- include/monitor/monitor.h | 2

Re: [Qemu-devel] [PATCH v2 01/12] qdev-monitor: print help to stdout

2018-09-07 Thread Thomas Huth
On 2018-09-07 09:59, Marc-André Lureau wrote: > qdev_device_help() is used from command line "-device help", or from > HMP "device_add". If used from command line, print help to stdout > (it is only printed on explicit demand). Good idea, it always bugged me that "-device help" behaves differently

[Qemu-devel] [PATCH v2 01/12] qdev-monitor: print help to stdout

2018-09-07 Thread Marc-André Lureau
qdev_device_help() is used from command line "-device help", or from HMP "device_add". If used from command line, print help to stdout (it is only printed on explicit demand). Signed-off-by: Marc-André Lureau --- include/monitor/monitor.h | 2 ++ monitor.c | 16 +---