Re: [Qemu-devel] [PATCH v2 01/12] qcow2: Add new overlap check functions

2015-02-04 Thread Max Reitz
On 2015-02-03 at 18:08, Eric Blake wrote: On 11/24/2014 08:56 AM, Max Reitz wrote: The existing qcow2 metadata overlap detection function used existing structures to determine the location of the image metadata, from plain fields such as l1_table_offset and l1_size in the BDRVQcowState, over ima

Re: [Qemu-devel] [PATCH v2 01/12] qcow2: Add new overlap check functions

2015-02-03 Thread Eric Blake
On 11/24/2014 08:56 AM, Max Reitz wrote: > The existing qcow2 metadata overlap detection function used existing > structures to determine the location of the image metadata, from plain > fields such as l1_table_offset and l1_size in the BDRVQcowState, over > image structures in memory such as the L

Re: [Qemu-devel] [PATCH v2 01/12] qcow2: Add new overlap check functions

2015-01-21 Thread Max Reitz
On 2015-01-21 at 11:53, Stefan Hajnoczi wrote: On Mon, Nov 24, 2014 at 04:56:49PM +0100, Max Reitz wrote: +static void build_window_bitmap(Qcow2MetadataList *mdl, +Qcow2MetadataWindow *window) +{ +int cache_i, oldest_cache_i = -1, i; +unsigned oldest_cache

Re: [Qemu-devel] [PATCH v2 01/12] qcow2: Add new overlap check functions

2015-01-21 Thread Stefan Hajnoczi
On Mon, Nov 24, 2014 at 04:56:49PM +0100, Max Reitz wrote: > +static void build_window_bitmap(Qcow2MetadataList *mdl, > +Qcow2MetadataWindow *window) > +{ > +int cache_i, oldest_cache_i = -1, i; > +unsigned oldest_cache_age = 0; > + > +for (cache_i = 0; c

Re: [Qemu-devel] [PATCH v2 01/12] qcow2: Add new overlap check functions

2014-11-25 Thread Max Reitz
On 2014-11-24 at 16:56, Max Reitz wrote: The existing qcow2 metadata overlap detection function used existing structures to determine the location of the image metadata, from plain fields such as l1_table_offset and l1_size in the BDRVQcowState, over image structures in memory such as the L1 tabl

[Qemu-devel] [PATCH v2 01/12] qcow2: Add new overlap check functions

2014-11-24 Thread Max Reitz
The existing qcow2 metadata overlap detection function used existing structures to determine the location of the image metadata, from plain fields such as l1_table_offset and l1_size in the BDRVQcowState, over image structures in memory such as the L1 table for the L2 tables' positions, or it even