Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

2019-04-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190417191805.28198-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify

Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

2019-04-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190417191805.28198-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify

Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

2019-04-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190417191805.28198-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify

Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

2019-04-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190417191805.28198-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify

Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

2019-04-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190417191805.28198-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify

Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

2019-04-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190417191805.28198-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify

Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

2019-04-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190417191805.28198-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify

Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

2019-04-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190417191805.28198-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify

Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

2019-04-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190417191805.28198-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify

Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

2019-04-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190417191805.28198-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify

Re: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

2019-04-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-arm...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190417191805.28198-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify

[Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function

2019-04-17 Thread Markus Armbruster
We pass around fprintf_function callbacks together a FILE * argument. Three cases: * We pass fprintf() and stdout, stderr or qemu_log_file. Okay. * We pass monitor_fprintf() together with the current monitor cast to FILE *. The type-punning is ugly. * We pass monitor_printf() cast to fprintf