Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting

2013-01-25 Thread Paolo Bonzini
Il 25/01/2013 11:33, Andreas Färber ha scritto: > Am 25.01.2013 11:25, schrieb Paolo Bonzini: >> Il 25/01/2013 10:21, Andreas Färber ha scritto: > > Ping. >>> I believe I was still waiting for an explanation why this qbus_init() >>> function must be exposed rather than one _new() and one _i

Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting

2013-01-25 Thread Andreas Färber
Am 25.01.2013 11:25, schrieb Paolo Bonzini: > Il 25/01/2013 10:21, Andreas Färber ha scritto: Ping. >> I believe I was still waiting for an explanation why this qbus_init() >> function must be exposed rather than one _new() and one _initialize() >> function... Not getting feedback on that

Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting

2013-01-25 Thread Paolo Bonzini
Il 25/01/2013 10:21, Andreas Färber ha scritto: >> > >> > Ping. > I believe I was still waiting for an explanation why this qbus_init() > function must be exposed rather than one _new() and one _initialize() > function... Not getting feedback on that, I was already considering > sending you an alt

Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting

2013-01-25 Thread Andreas Färber
Am 25.01.2013 10:10, schrieb Paolo Bonzini: > Il 21/01/2013 13:30, Paolo Bonzini ha scritto: >> This series makes the ref_count field of device and bus objects actually >> match the number of references that the objects have. Once this is >> done, the question "how do I delete an object?" has a s

Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting

2013-01-25 Thread Paolo Bonzini
Il 21/01/2013 13:30, Paolo Bonzini ha scritto: > This series makes the ref_count field of device and bus objects actually > match the number of references that the objects have. Once this is > done, the question "how do I delete an object?" has a simple answer: > use object_unparent if the object

Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting

2013-01-21 Thread Anthony Liguori
Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding styl

[Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting

2013-01-21 Thread Paolo Bonzini
This series makes the ref_count field of device and bus objects actually match the number of references that the objects have. Once this is done, the question "how do I delete an object?" has a simple answer: use object_unparent if the object is reachable from the QOM tree, else use object_unref.