Re: [Qemu-devel] [PATCH v2 0/6] monitor: misc fixes

2018-12-03 Thread Markus Armbruster
Found only minor issues. v3 should do the trick. Thanks!

Re: [Qemu-devel] [PATCH v2 0/6] monitor: misc fixes

2018-10-30 Thread Markus Armbruster
Marc-André Lureau writes: > Hi, > > Here is a small series of fixes for the monitor, mostly related to > threading issues. Series looks good on first glance, but thread safety is subtle business, so I'd like to give it a bit more time for review. Bug fixes like these can go in after soft freeze

Re: [Qemu-devel] [PATCH v2 0/6] monitor: misc fixes

2018-10-30 Thread Marc-André Lureau
Hi On Tue, Oct 30, 2018 at 9:48 AM Peter Xu wrote: > > On Mon, Oct 29, 2018 at 04:57:27PM +0400, Marc-André Lureau wrote: > > Hi, > > > > Here is a small series of fixes for the monitor, mostly related to > > threading issues. > > Hi, Marc-André, Markus, > > I'd be glad to know how you think abou

Re: [Qemu-devel] [PATCH v2 0/6] monitor: misc fixes

2018-10-29 Thread Peter Xu
On Mon, Oct 29, 2018 at 04:57:27PM +0400, Marc-André Lureau wrote: > Hi, > > Here is a small series of fixes for the monitor, mostly related to > threading issues. Hi, Marc-André, Markus, I'd be glad to know how you think about these monitor series, considering that I just noticed it's exactly s

[Qemu-devel] [PATCH v2 0/6] monitor: misc fixes

2018-10-29 Thread Marc-André Lureau
Hi, Here is a small series of fixes for the monitor, mostly related to threading issues. v2: after Peter review - patch 2: fix resuming with oob=off - patch 4: keep MUX case explicit, improve commit message Marc-André Lureau (6): monitor: inline ambiguous helper functions monitor: accept c