Re: [Qemu-devel] [PATCH v2 0/6] migration: objectify MigrationState

2017-06-19 Thread Markus Armbruster
Peter Xu writes: > On Fri, Jun 09, 2017 at 04:02:37PM +0200, Markus Armbruster wrote: >> Test compile gripes: >> >> hw/xen/xen-common.c: In function ‘xen_init’: >> hw/xen/xen-common.c:147:5: warning: implicit declaration of function >> ‘register_compat_prop’ [-Wimplicit-function-declara

Re: [Qemu-devel] [PATCH v2 0/6] migration: objectify MigrationState

2017-06-12 Thread Peter Xu
On Fri, Jun 09, 2017 at 04:02:37PM +0200, Markus Armbruster wrote: > Test compile gripes: > > hw/xen/xen-common.c: In function ‘xen_init’: > hw/xen/xen-common.c:147:5: warning: implicit declaration of function > ‘register_compat_prop’ [-Wimplicit-function-declaration] > register_

Re: [Qemu-devel] [PATCH v2 0/6] migration: objectify MigrationState

2017-06-09 Thread Juan Quintela
Markus Armbruster wrote: > Test compile gripes: > > hw/xen/xen-common.c: In function ‘xen_init’: > hw/xen/xen-common.c:147:5: warning: implicit declaration of function > ‘register_compat_prop’ [-Wimplicit-function-declaration] > register_compat_prop("migration", "store-global-sta

Re: [Qemu-devel] [PATCH v2 0/6] migration: objectify MigrationState

2017-06-09 Thread Markus Armbruster
Test compile gripes: hw/xen/xen-common.c: In function ‘xen_init’: hw/xen/xen-common.c:147:5: warning: implicit declaration of function ‘register_compat_prop’ [-Wimplicit-function-declaration] register_compat_prop("migration", "store-global-state", "off"); ^~~

Re: [Qemu-devel] [PATCH v2 0/6] migration: objectify MigrationState

2017-06-09 Thread Peter Xu
On Fri, Jun 09, 2017 at 09:48:32AM +0200, Juan Quintela wrote: > Peter Xu wrote: > > v2 > > - (I didn't add Juan's r-b since I touched the patches) > > - remove once parameter in migrate_get_current() since not needed > > - add one more patch to export register_compat_prop(), then use it in > >

Re: [Qemu-devel] [PATCH v2 0/6] migration: objectify MigrationState

2017-06-09 Thread Juan Quintela
Peter Xu wrote: > v2 > - (I didn't add Juan's r-b since I touched the patches) > - remove once parameter in migrate_get_current() since not needed > - add one more patch to export register_compat_prop(), then use it in > the following patches in xen_init(). > > I picked this topic out as suggest

[Qemu-devel] [PATCH v2 0/6] migration: objectify MigrationState

2017-06-08 Thread Peter Xu
v2 - (I didn't add Juan's r-b since I touched the patches) - remove once parameter in migrate_get_current() since not needed - add one more patch to export register_compat_prop(), then use it in the following patches in xen_init(). I picked this topic out as suggested by Juan. Also I did what Ju