Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-05 Thread Anthony Liguori
On 03/05/2012 02:53 AM, Kevin Wolf wrote: Am 01.03.2012 22:10, schrieb Anthony Liguori: On 03/01/2012 05:21 AM, Paolo Bonzini wrote: This implements all ingredients to establish mirrored writes. The drive-reopen command that is used to terminate mirrored writes is not included in this series.

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 15:47, Anthony Liguori ha scritto: >> How about coupling the types with independently available commands for >> now? We would rename 'snapshot' to 'blockdev-snapshot-sync', which does >> the same thing outside of transactions. The mirror patches would then >> introduce a 'drive-mirror

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 13:13, Kevin Wolf ha scritto: >> Makes sense. It would also be a good excuse to port >> blockdev-snapshot-sync to the new fail-safe way. I'll refresh my >> patches if there's consensus. > > Will you also replace 'blockdev-transaction' by 'transaction' to keep > things generic at th

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-05 Thread Kevin Wolf
Am 05.03.2012 10:28, schrieb Paolo Bonzini: > Il 05/03/2012 09:53, Kevin Wolf ha scritto: I think we need some sort of introspection method too in order for clients to figure out when the command is extended. >> How about coupling the types with independently available command

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 09:53, Kevin Wolf ha scritto: >> > >> > I think we need some sort of introspection method too in order for clients >> > to >> > figure out when the command is extended. > How about coupling the types with independently available commands for > now? We would rename 'snapshot' to 'bl

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-05 Thread Kevin Wolf
Am 01.03.2012 22:10, schrieb Anthony Liguori: > On 03/01/2012 05:21 AM, Paolo Bonzini wrote: >> This implements all ingredients to establish mirrored writes. >> The drive-reopen command that is used to terminate mirrored writes >> is not included in this series. >> >> Tested with the following scen

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-02 Thread Anthony Liguori
On 03/01/2012 03:36 PM, Anthony Liguori wrote: On 03/01/2012 03:30 PM, Eric Blake wrote: On 03/01/2012 02:10 PM, Anthony Liguori wrote: 2) Execute the following QMP command { "execute": "qmp_capabilities" } { "execute": "blockdev-transaction", "arguments": {'actions': [ { 'type': 'snapshot', '

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-01 Thread Anthony Liguori
On 03/01/2012 03:30 PM, Eric Blake wrote: On 03/01/2012 02:10 PM, Anthony Liguori wrote: 2) Execute the following QMP command { "execute": "qmp_capabilities" } { "execute": "blockdev-transaction", "arguments": {'actions': [ { 'type': 'snapshot', 'data' : { 'device': 'ide0-hd0'

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-01 Thread Eric Blake
On 03/01/2012 02:10 PM, Anthony Liguori wrote: >> 2) Execute the following QMP command >> >> { "execute": "qmp_capabilities" } >> { "execute": "blockdev-transaction", "arguments": >>{'actions': [ >> { 'type': 'snapshot', 'data' : >>{ 'device': 'ide0-hd0', 'snapshot-file': >> '/home

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-01 Thread Anthony Liguori
On 03/01/2012 05:21 AM, Paolo Bonzini wrote: This implements all ingredients to establish mirrored writes. The drive-reopen command that is used to terminate mirrored writes is not included in this series. Tested with the following scenarios: a) mirror only 1) create base.qcow2 and start QEMU

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-01 Thread Luiz Capitulino
On Thu, 01 Mar 2012 17:18:04 +0100 Kevin Wolf wrote: > Am 01.03.2012 17:02, schrieb Luiz Capitulino: > > On Thu, 1 Mar 2012 12:21:42 +0100 > > Paolo Bonzini wrote: > > > >> This implements all ingredients to establish mirrored writes. > > > > This looks good to me. I just have two comments: >

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-01 Thread Kevin Wolf
Am 01.03.2012 17:02, schrieb Luiz Capitulino: > On Thu, 1 Mar 2012 12:21:42 +0100 > Paolo Bonzini wrote: > >> This implements all ingredients to establish mirrored writes. > > This looks good to me. I just have two comments: > > 1. I'm wondering if it would make more sense to have this transa

Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-01 Thread Luiz Capitulino
On Thu, 1 Mar 2012 12:21:42 +0100 Paolo Bonzini wrote: > This implements all ingredients to establish mirrored writes. This looks good to me. I just have two comments: 1. I'm wondering if it would make more sense to have this transaction operation in qmp instead of the block layer. Looks

[Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction

2012-03-01 Thread Paolo Bonzini
This implements all ingredients to establish mirrored writes. The drive-reopen command that is used to terminate mirrored writes is not included in this series. Tested with the following scenarios: a) mirror only 1) create base.qcow2 and start QEMU with it 2) Execute the following QMP command