Re: [Qemu-devel] [PATCH v2 0/4] Allow QOM struct fields to be marked as private

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 18:21, Peter Maydell ha scritto: On 23 May 2014 15:33, Paolo Bonzini wrote: Il 23/05/2014 13:50, Peter Maydell ha scritto: On 23 May 2014 12:23, Andreas Färber wrote: Am 23.05.2014 13:13, schrieb Peter Maydell: Ping? I believe I remarked that in the example typedef struct Fo

Re: [Qemu-devel] [PATCH v2 0/4] Allow QOM struct fields to be marked as private

2014-05-23 Thread Peter Maydell
On 23 May 2014 15:33, Paolo Bonzini wrote: > Il 23/05/2014 13:50, Peter Maydell ha scritto: >> On 23 May 2014 12:23, Andreas Färber wrote: >>> Am 23.05.2014 13:13, schrieb Peter Maydell: Ping? >>> >>> I believe I remarked that in the example >>> typedef struct Foo { >>> would be more in line

Re: [Qemu-devel] [PATCH v2 0/4] Allow QOM struct fields to be marked as private

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 13:50, Peter Maydell ha scritto: > On 23 May 2014 12:23, Andreas Färber wrote: >> Am 23.05.2014 13:13, schrieb Peter Maydell: >>> Ping? >> >> I believe I remarked that in the example >> typedef struct Foo { >> would be more in line with our Coding Style and majority of users. >> >> O

Re: [Qemu-devel] [PATCH v2 0/4] Allow QOM struct fields to be marked as private

2014-05-23 Thread Peter Maydell
On 23 May 2014 12:23, Andreas Färber wrote: > Am 23.05.2014 13:13, schrieb Peter Maydell: >> Ping? > > I believe I remarked that in the example > typedef struct Foo { > would be more in line with our Coding Style and majority of users. > > Other than that, I have no objections and assumed you'll t

Re: [Qemu-devel] [PATCH v2 0/4] Allow QOM struct fields to be marked as private

2014-05-23 Thread Andreas Färber
Am 23.05.2014 13:13, schrieb Peter Maydell: > On 9 May 2014 16:56, Peter Maydell wrote: >> This patch series provides infrastructure and documentation >> for marking QOM struct fields as private to the class implementation. >> >> Patch 1 is the implementation (which is a trivial five lines!) and >

Re: [Qemu-devel] [PATCH v2 0/4] Allow QOM struct fields to be marked as private

2014-05-23 Thread Peter Maydell
On 9 May 2014 16:56, Peter Maydell wrote: > This patch series provides infrastructure and documentation > for marking QOM struct fields as private to the class implementation. > > Patch 1 is the implementation (which is a trivial five lines!) and > documentation of the code pattern that it's inten

[Qemu-devel] [PATCH v2 0/4] Allow QOM struct fields to be marked as private

2014-05-09 Thread Peter Maydell
This patch series provides infrastructure and documentation for marking QOM struct fields as private to the class implementation. Patch 1 is the implementation (which is a trivial five lines!) and documentation of the code pattern that it's intended to be used with. Patches 2, 3 and 4 are example