Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-17 Thread Gonglei (Arei)
> but switching all usb over to realize is a bigger project indeed. > Hi, Gerd I want to do this job which converting USB devices from init to realize. So all the implementations can use error_setg instead of error_report for reporting error. Include those devices as below: name "usb-host", bu

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Wednesday, September 17, 2014 12:16 AM > To: Gerd Hoffmann > Cc: Gonglei (Arei); Huangweidong (C); qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report > > Gerd Hof

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 16, 2014 10:26 PM > To: Paolo Bonzini > Cc: Gonglei (Arei); qemu-devel@nongnu.org; Huangweidong (C); > kra...@redhat.com > Subject: Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_re

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> > Gonglei (2): >> > redirect.c: Don't use qerror_report() >> > dev-network: Don't use qerror_report_err() > >> Hi, Gerd >> Would you like to apply this patch series at present? Thanks! > > Picked it up now. Originally dropped due to review comments from pa

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Markus Armbruster
Paolo Bonzini writes: > Il 16/09/2014 15:54, Gonglei (Arei) ha scritto: >>> -Original Message- >>> From: Gonglei (Arei) >>> Sent: Friday, September 12, 2014 3:31 PM >>> To: qemu-devel@nongnu.org >>> Cc: kra...@redhat.com; Huangweidong (C); arm...@redhat.com; Gonglei >>> (Arei) >>> Subject

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Gerd Hoffmann
Hi, > > Gonglei (2): > > redirect.c: Don't use qerror_report() > > dev-network: Don't use qerror_report_err() > Hi, Gerd > Would you like to apply this patch series at present? Thanks! Picked it up now. Originally dropped due to review comments from paolo, but switching all usb over to r

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Paolo Bonzini
Il 16/09/2014 15:54, Gonglei (Arei) ha scritto: >> -Original Message- >> From: Gonglei (Arei) >> Sent: Friday, September 12, 2014 3:31 PM >> To: qemu-devel@nongnu.org >> Cc: kra...@redhat.com; Huangweidong (C); arm...@redhat.com; Gonglei >> (Arei) >> Subject: [PATCH v2 0/2] usb: Don't use q

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Gonglei (Arei)
> -Original Message- > From: Gonglei (Arei) > Sent: Friday, September 12, 2014 3:31 PM > To: qemu-devel@nongnu.org > Cc: kra...@redhat.com; Huangweidong (C); arm...@redhat.com; Gonglei > (Arei) > Subject: [PATCH v2 0/2] usb: Don't use qerror_report > > From: Gonglei > > qerror_report() i

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 12, 2014 4:59 PM > Subject: Re: [PATCH v2 0/2] usb: Don't use qerror_report > > Il 12/09/2014 10:50, Gonglei (Arei) ha scritto: > >> > Any chance you could convert USB from init to realize

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Paolo Bonzini
Il 12/09/2014 10:50, Gonglei (Arei) ha scritto: >> > Any chance you could convert USB from init to realize, instead? Then >> > you can remove the error printing altogether, and just the obsolete >> > functions. >> > > As far as I can tell, almost all devices belong to USB sub-system are > using i

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 12, 2014 4:35 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); kra...@redhat.com; arm...@redhat.com > Subject: Re: [PATCH v2 0/2] usb: Don't use qerror_report > > Il

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Paolo Bonzini
Il 12/09/2014 09:30, arei.gong...@huawei.com ha scritto: > From: Gonglei > > qerror_report() is a transitional interface to help with converting > existing HMP commands to QMP. It should not be used elsewhere. > > v2 -> v1: > - update including head files, remove qerror.h and monitor.h, >a

[Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread arei.gonglei
From: Gonglei qerror_report() is a transitional interface to help with converting existing HMP commands to QMP. It should not be used elsewhere. v2 -> v1: - update including head files, remove qerror.h and monitor.h, add error-report.h (Markus) - add 'Reviewed-by' tag. Gonglei (2): redi