Re: [Qemu-devel] [PATCH v2 0/2] mirror dead-lock

2018-12-03 Thread Eric Blake
On 12/3/18 8:26 AM, Max Reitz wrote: So because apparently there is going to be an rc4 anyway (like basically always...), I'd really like to bring this fix into it, unless there are any objections from anyone (though all of you are more than welcome to explicitly agree, too :-)). I agree with

Re: [Qemu-devel] [PATCH v2 0/2] mirror dead-lock

2018-12-03 Thread Kevin Wolf
Am 29.11.2018 um 11:17 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > v2: add fix:) > > We've faced the following mirror bug: > > Just run mirror on qcow2 image more than 1G, and qemu is in dead lock. > > Dead lock described in 01, in short, we have extra aio_context_acquire > and

Re: [Qemu-devel] [PATCH v2 0/2] mirror dead-lock

2018-12-03 Thread Peter Maydell
On Mon, 3 Dec 2018 at 14:03, Max Reitz wrote: > > On 29.11.18 11:17, Vladimir Sementsov-Ogievskiy wrote: > > Hi all! > > > > v2: add fix:) > > > > We've faced the following mirror bug: > > > > Just run mirror on qcow2 image more than 1G, and qemu is in dead lock. > > So because apparently there is

Re: [Qemu-devel] [PATCH v2 0/2] mirror dead-lock

2018-12-03 Thread Max Reitz
On 03.12.18 15:13, Vladimir Sementsov-Ogievskiy wrote: > 03.12.2018 16:59, Max Reitz wrote: >> On 29.11.18 11:17, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all! >>> >>> v2: add fix:) >>> >>> We've faced the following mirror bug: >>> >>> Just run mirror on qcow2 image more than 1G, and qemu is in d

Re: [Qemu-devel] [PATCH v2 0/2] mirror dead-lock

2018-12-03 Thread Vladimir Sementsov-Ogievskiy
03.12.2018 16:59, Max Reitz wrote: > On 29.11.18 11:17, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> v2: add fix:) >> >> We've faced the following mirror bug: >> >> Just run mirror on qcow2 image more than 1G, and qemu is in dead lock. > > So because apparently there is going to be an rc4

Re: [Qemu-devel] [PATCH v2 0/2] mirror dead-lock

2018-12-03 Thread Max Reitz
On 29.11.18 11:17, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > v2: add fix:) > > We've faced the following mirror bug: > > Just run mirror on qcow2 image more than 1G, and qemu is in dead lock. So because apparently there is going to be an rc4 anyway (like basically always...), I'd really

[Qemu-devel] [PATCH v2 0/2] mirror dead-lock

2018-11-29 Thread Vladimir Sementsov-Ogievskiy
Hi all! v2: add fix:) We've faced the following mirror bug: Just run mirror on qcow2 image more than 1G, and qemu is in dead lock. Dead lock described in 01, in short, we have extra aio_context_acquire and aio_context_release around blk_aio_pwritev in mirror_read_complete. So, write may yield t