Re: [Qemu-devel] [PATCH v2] x86: svm: Always clear event_inj on vmexit

2010-06-30 Thread Aurelien Jarno
On Wed, Jun 02, 2010 at 08:49:14AM +0200, Jan Kiszka wrote: > Erik van der Kouwe wrote: > > Hi, > > > >> We currently only clear SVM_EVTINJ_VALID after successful interrupt > >> delivery. This apparently does not match real hardware which clears the > >> whole event_inj field on every vmexit, incl

Re: [Qemu-devel] [PATCH v2] x86: svm: Always clear event_inj on vmexit

2010-06-02 Thread Erik van der Kouwe
Hi, Sorry, can't follow this ATM. But maybe you mean this: there is indeed a problem with removing the clearance of event_inj.invalid as it may be later on transferred into exit_int_info. And if we succeed with injecting the event, that field must not remaind valid. Correct. OK, here is v2:

[Qemu-devel] [PATCH v2] x86: svm: Always clear event_inj on vmexit

2010-06-01 Thread Jan Kiszka
Erik van der Kouwe wrote: > Hi, > >> We currently only clear SVM_EVTINJ_VALID after successful interrupt >> delivery. This apparently does not match real hardware which clears the >> whole event_inj field on every vmexit, including unsuccessful interrupt >> delivery. > > Thanks for the patch. It