Re: [Qemu-devel] [PATCH v2] vmgenid-test: use boot-sector infrastructure

2017-07-14 Thread Peter Maydell
On 14 July 2017 at 16:49, Ben Warren wrote: > Hi Michael, > > Looks good. Thanks for taking care of this. > > On Jul 14, 2017, at 8:30 AM, Michael S. Tsirkin wrote: > > There's no requirement for RSDP to be installed last > by the firmware, so in rare cases vmgen id test hits > a race: RSDP is t

Re: [Qemu-devel] [PATCH v2] vmgenid-test: use boot-sector infrastructure

2017-07-14 Thread Ben Warren via Qemu-devel
Hi Michael, Looks good. Thanks for taking care of this. > On Jul 14, 2017, at 8:30 AM, Michael S. Tsirkin wrote: > > There's no requirement for RSDP to be installed last > by the firmware, so in rare cases vmgen id test hits > a race: RSDP is there but VM GEN ID isn't. > > To fix, switch to co

[Qemu-devel] [PATCH v2] vmgenid-test: use boot-sector infrastructure

2017-07-14 Thread Michael S. Tsirkin
There's no requirement for RSDP to be installed last by the firmware, so in rare cases vmgen id test hits a race: RSDP is there but VM GEN ID isn't. To fix, switch to common boot sector infrastructure. Cc: Laszlo Ersek Cc: Peter Maydell Cc: Ben Warren Signed-off-by: Michael S. Tsirkin --- Ch