Re: [Qemu-devel] [PATCH v2] vmdk: fix metadata write regression

2016-07-08 Thread Max Reitz
On 07.07.2016 10:42, Reda Sallahi wrote: > Commit "cdeaf1f vmdk: add bdrv_co_write_zeroes" causes a regression on > writes. It writes metadata after every write instead of doing it only once > for each cluster. > > vmdk_pwritev() writes metadata whenever m_data is set as valid so this patch > sets

Re: [Qemu-devel] [PATCH v2] vmdk: fix metadata write regression

2016-07-07 Thread Fam Zheng
On Thu, 07/07 10:42, Reda Sallahi wrote: > Commit "cdeaf1f vmdk: add bdrv_co_write_zeroes" causes a regression on > writes. It writes metadata after every write instead of doing it only once > for each cluster. > > vmdk_pwritev() writes metadata whenever m_data is set as valid so this patch > sets

[Qemu-devel] [PATCH v2] vmdk: fix metadata write regression

2016-07-07 Thread Reda Sallahi
Commit "cdeaf1f vmdk: add bdrv_co_write_zeroes" causes a regression on writes. It writes metadata after every write instead of doing it only once for each cluster. vmdk_pwritev() writes metadata whenever m_data is set as valid so this patch sets m_data as valid only when we have a new cluster whic