On Thu, 4 Apr 2019 at 17:05, Igor Mammedov wrote:
> On Tue, 2 Apr 2019 23:23:42 +0700
> Peter Maydell wrote:
> > One wrinkle to watch out for is code paths that are used in the
> > linux-user emulator, where there is no machine at all... For instance
> > cpu_common_realizefn() handles this case b
On Tue, 2 Apr 2019 23:23:42 +0700
Peter Maydell wrote:
> On Tue, 2 Apr 2019 at 23:13, Markus Armbruster wrote:
> >
> > Igor Mammedov writes:
> > > maybe we can assert in qdev_get_machine() if machine hasn't been created
> > > yet?
> > > with this at least it will be hard to misuse function o
On 2019/4/3 0:13, Markus Armbruster wrote:
Igor Mammedov writes:
On Tue, 2 Apr 2019 21:09:39 +0800
Like Xu wrote:
On 2019/4/2 19:27, Markus Armbruster wrote:
Like Xu writes:
This patch makes the remaining dozen or so uses of the global
current_machine outside vl.c use qdev_get_machin
On Wed, 3 Apr 2019 at 02:16, Eduardo Habkost wrote:
>
> On Tue, Apr 02, 2019 at 11:23:42PM +0700, Peter Maydell wrote:
> > One wrinkle to watch out for is code paths that are used in the
> > linux-user emulator, where there is no machine at all... For instance
> > cpu_common_realizefn() handles th
On Tue, Apr 02, 2019 at 11:23:42PM +0700, Peter Maydell wrote:
> On Tue, 2 Apr 2019 at 23:13, Markus Armbruster wrote:
> >
> > Igor Mammedov writes:
> > > maybe we can assert in qdev_get_machine() if machine hasn't been created
> > > yet?
> > > with this at least it will be hard to misuse functi
On Tue, 2 Apr 2019 at 23:13, Markus Armbruster wrote:
>
> Igor Mammedov writes:
> > maybe we can assert in qdev_get_machine() if machine hasn't been created
> > yet?
> > with this at least it will be hard to misuse function or catch invalid
> > users.
> > (but it still might miss some use cases
Igor Mammedov writes:
> On Tue, 2 Apr 2019 21:09:39 +0800
> Like Xu wrote:
>
>> On 2019/4/2 19:27, Markus Armbruster wrote:
>> > Like Xu writes:
>> >
>> >> This patch makes the remaining dozen or so uses of the global
>> >> current_machine outside vl.c use qdev_get_machine() instead,
>> >> a
On Tue, 2 Apr 2019 21:09:39 +0800
Like Xu wrote:
> On 2019/4/2 19:27, Markus Armbruster wrote:
> > Like Xu writes:
> >
> >> This patch makes the remaining dozen or so uses of the global
> >> current_machine outside vl.c use qdev_get_machine() instead,
> >> and then make current_machine local
On 2019/4/2 19:27, Markus Armbruster wrote:
Like Xu writes:
This patch makes the remaining dozen or so uses of the global
current_machine outside vl.c use qdev_get_machine() instead,
and then make current_machine local to vl.c instead of global.
Signed-off-by: Like Xu
You effectively repla
Like Xu writes:
> This patch makes the remaining dozen or so uses of the global
> current_machine outside vl.c use qdev_get_machine() instead,
> and then make current_machine local to vl.c instead of global.
>
> Signed-off-by: Like Xu
You effectively replace
current_machine
by
MACHIN
This patch makes the remaining dozen or so uses of the global
current_machine outside vl.c use qdev_get_machine() instead,
and then make current_machine local to vl.c instead of global.
Signed-off-by: Like Xu
---
Changes in v2:
- make the variable current_machine "static" (Thomas Huth)
---
11 matches
Mail list logo
