Re: [Qemu-devel] [PATCH v2] virtio-rng: process pending requests when driver is ready

2018-07-01 Thread Pankaj Gupta
> > On Wed, Jun 27, 2018 at 04:55:20PM +0530, Pankaj Gupta wrote: > > +static void virtio_rng_set_status(VirtIODevice *vdev, uint8_t status) > > +{ > > +VirtIORNG *vrng = VIRTIO_RNG(vdev); > > + > > +if (!vdev->vm_running) { > > +return; > > +} > > +vdev->status = status;

Re: [Qemu-devel] [PATCH v2] virtio-rng: process pending requests when driver is ready

2018-06-29 Thread Stefan Hajnoczi
On Wed, Jun 27, 2018 at 04:55:20PM +0530, Pankaj Gupta wrote: > +static void virtio_rng_set_status(VirtIODevice *vdev, uint8_t status) > +{ > +VirtIORNG *vrng = VIRTIO_RNG(vdev); > + > +if (!vdev->vm_running) { > +return; > +} > +vdev->status = status; Please add a comment

Re: [Qemu-devel] [PATCH v2] virtio-rng: process pending requests when driver is ready

2018-06-27 Thread Pankaj Gupta
> > On Wed, Jun 27, 2018 at 04:55:20PM +0530, Pankaj Gupta wrote: > > virtio-rng device causing old guest kernels(2.6.32) to hang on latest > > qemu. > > The driver attempts to read from the virtio-rng device too early in it's > > initialization. Qemu detects guest is not ready and returns,

Re: [Qemu-devel] [PATCH v2] virtio-rng: process pending requests when driver is ready

2018-06-27 Thread Daniel P . Berrangé
On Wed, Jun 27, 2018 at 04:55:20PM +0530, Pankaj Gupta wrote: > virtio-rng device causing old guest kernels(2.6.32) to hang on latest qemu. > The driver attempts to read from the virtio-rng device too early in it's > initialization. Qemu detects guest is not ready and returns, resulting in > ha

[Qemu-devel] [PATCH v2] virtio-rng: process pending requests when driver is ready

2018-06-27 Thread Pankaj Gupta
virtio-rng device causing old guest kernels(2.6.32) to hang on latest qemu. The driver attempts to read from the virtio-rng device too early in it's initialization. Qemu detects guest is not ready and returns, resulting in hang. Fix is to handle pending request when guest is running and drive