Re: [Qemu-devel] [PATCH v2] virtio-blk: add default serial id

2012-10-11 Thread Stefan Hajnoczi
On Wed, Oct 10, 2012 at 10:07:01AM +0800, Dave Young wrote: > On 10/09/2012 04:31 PM, Stefan Hajnoczi wrote: > > > On Tue, Oct 09, 2012 at 10:27:26AM +0800, Dave Young wrote: > >> On 10/05/2012 04:14 PM, Stefan Hajnoczi wrote: > >> > >>> On Sun, Sep 23, 2012 at 10:37:09AM +0800, Dave Young wrote:

Re: [Qemu-devel] [PATCH v2] virtio-blk: add default serial id

2012-10-09 Thread Dave Young
On 10/09/2012 04:31 PM, Stefan Hajnoczi wrote: > On Tue, Oct 09, 2012 at 10:27:26AM +0800, Dave Young wrote: >> On 10/05/2012 04:14 PM, Stefan Hajnoczi wrote: >> >>> On Sun, Sep 23, 2012 at 10:37:09AM +0800, Dave Young wrote: For the serial number decreasing issue, I think there's only these

Re: [Qemu-devel] [PATCH v2] virtio-blk: add default serial id

2012-10-09 Thread Stefan Hajnoczi
On Tue, Oct 09, 2012 at 10:27:26AM +0800, Dave Young wrote: > On 10/05/2012 04:14 PM, Stefan Hajnoczi wrote: > > > On Sun, Sep 23, 2012 at 10:37:09AM +0800, Dave Young wrote: > >> For the serial number decreasing issue, I think there's only these two > >> ways to > >> select, there's no ideal way

Re: [Qemu-devel] [PATCH v2] virtio-blk: add default serial id

2012-10-08 Thread Dave Young
On 10/05/2012 04:14 PM, Stefan Hajnoczi wrote: > On Sun, Sep 23, 2012 at 10:37:09AM +0800, Dave Young wrote: >> For the serial number decreasing issue, I think there's only these two ways >> to >> select, there's no ideal way to resolve this issue. >> My use case for this is for the kdump kernel

Re: [Qemu-devel] [PATCH v2] virtio-blk: add default serial id

2012-10-05 Thread Stefan Hajnoczi
On Sun, Sep 23, 2012 at 10:37:09AM +0800, Dave Young wrote: > For the serial number decreasing issue, I think there's only these two ways to > select, there's no ideal way to resolve this issue. > My use case for this is for the kdump kernel to find proper disks, > after 1st kernel crashing 2nd ker

Re: [Qemu-devel] [PATCH v2] virtio-blk: add default serial id

2012-09-22 Thread Dave Young
On Fri, Sep 21, 2012 at 08:15:38AM -0600, Eric Blake wrote: > On 09/21/2012 07:30 AM, Dave Young wrote: > > > > For virtio block device, if user does not specify the serial attribute, > > There will be no serial availabe, this is not convenient for identifying > > the disk. > > > > Doing somethin

Re: [Qemu-devel] [PATCH v2] virtio-blk: add default serial id

2012-09-21 Thread Eric Blake
On 09/21/2012 07:30 AM, Dave Young wrote: > > For virtio block device, if user does not specify the serial attribute, > There will be no serial availabe, this is not convenient for identifying > the disk. > > Doing something similar to ide disks, add a "VD?" default serial > number if user do

[Qemu-devel] [PATCH v2] virtio-blk: add default serial id

2012-09-21 Thread Dave Young
For virtio block device, if user does not specify the serial attribute, There will be no serial availabe, this is not convenient for identifying the disk. Doing something similar to ide disks, add a "VD?" default serial number if user does not specify it. [v1->v2 address comments from Eric B