Re: [Qemu-devel] [PATCH v2] vga: Implement blinking of text cursor

2012-07-04 Thread Stefan Weil
Hi Jan, please see my comments below. Am 04.07.2012 15:40, schrieb Jan Kiszka: Let the text cursor blink at 5 Hz. No timer is used, instead we rely on the fact that the display is updated periodically. Signed-off-by: Jan Kiszka --- Changes in v2: - avoid full screen updates for cursor blin

Re: [Qemu-devel] [PATCH v2] vga: Implement blinking of text cursor

2012-07-04 Thread Jan Kiszka
On 2012-07-04 18:26, Stefan Weil wrote: > Hi Jan, > > please see my comments below. > > > Am 04.07.2012 15:40, schrieb Jan Kiszka: >> Let the text cursor blink at 5 Hz. No timer is used, instead we rely on >> the fact that the display is updated periodically. >> >> Signed-off-by: Jan Kiszka >> -

[Qemu-devel] [PATCH v2] vga: Implement blinking of text cursor

2012-07-04 Thread Jan Kiszka
Let the text cursor blink at 5 Hz. No timer is used, instead we rely on the fact that the display is updated periodically. Signed-off-by: Jan Kiszka --- Changes in v2: - avoid full screen updates for cursor blinking - convert cursor_blink_state to cursor_visible_phase hw/vga.c | 14 +++