Re: [Qemu-devel] [PATCH v2] vfio/common: Introduce vfio_set_irq_signaling helper

2019-06-03 Thread Alex Williamson
On Mon, 3 Jun 2019 20:51:50 +0200 Auger Eric wrote: > Hi Alex, > > On 6/3/19 8:31 PM, Alex Williamson wrote: > > On Mon, 27 May 2019 11:59:04 +0200 > > Eric Auger wrote: > > > >> The code used to assign an interrupt index/subindex to an > >> eventfd is duplicated many times. Let's introduce

Re: [Qemu-devel] [PATCH v2] vfio/common: Introduce vfio_set_irq_signaling helper

2019-06-03 Thread Auger Eric
Hi Alex, On 6/3/19 9:36 PM, Alex Williamson wrote: > On Mon, 3 Jun 2019 20:51:50 +0200 > Auger Eric wrote: > >> Hi Alex, >> >> On 6/3/19 8:31 PM, Alex Williamson wrote: >>> On Mon, 27 May 2019 11:59:04 +0200 >>> Eric Auger wrote: >>> The code used to assign an interrupt index/subindex t

Re: [Qemu-devel] [PATCH v2] vfio/common: Introduce vfio_set_irq_signaling helper

2019-06-03 Thread Auger Eric
Hi Alex, On 6/3/19 8:31 PM, Alex Williamson wrote: > On Mon, 27 May 2019 11:59:04 +0200 > Eric Auger wrote: > >> The code used to assign an interrupt index/subindex to an >> eventfd is duplicated many times. Let's introduce an helper that >> allows to set/unset the signaling for an ACTION_TRIGGE

Re: [Qemu-devel] [PATCH v2] vfio/common: Introduce vfio_set_irq_signaling helper

2019-06-03 Thread Alex Williamson
On Mon, 27 May 2019 11:59:04 +0200 Eric Auger wrote: > The code used to assign an interrupt index/subindex to an > eventfd is duplicated many times. Let's introduce an helper that > allows to set/unset the signaling for an ACTION_TRIGGER, > ACTION_MASK or ACTION_UNMASK action. > > Signed-off-by:

[Qemu-devel] [PATCH v2] vfio/common: Introduce vfio_set_irq_signaling helper

2019-05-27 Thread Eric Auger
The code used to assign an interrupt index/subindex to an eventfd is duplicated many times. Let's introduce an helper that allows to set/unset the signaling for an ACTION_TRIGGER, ACTION_MASK or ACTION_UNMASK action. Signed-off-by: Eric Auger --- v1 -> v2: - don't call GET_IRQ_INFO in vfio_set_