Re: [Qemu-devel] [PATCH v2] util/async: avoid NULL pointer dereference

2018-06-27 Thread Stefan Hajnoczi
On Tue, Jun 26, 2018 at 10:51:50AM +0800, WangJie (Pluto) wrote: > Thanks Stefan, will you push it to master branch? Hi, I have replaced this patch with "[PATCH v4] linux-aio: properly bubble up errors from initialization". It solves the issue at initialization time so aio_get_linux_aio() callers

Re: [Qemu-devel] [PATCH v2] util/async: avoid NULL pointer dereference

2018-06-25 Thread WangJie (Pluto)
Thanks Stefan, will you push it to master branch? On 2018/6/18 23:50, Stefan Hajnoczi wrote: > On Tue, Jun 12, 2018 at 07:26:25AM +0800, Jie Wang wrote: >> if laio_init create linux_aio failed and return NULL, NULL pointer >> dereference will occur when laio_attach_aio_context dereference >> linux

Re: [Qemu-devel] [PATCH v2] util/async: avoid NULL pointer dereference

2018-06-18 Thread Stefan Hajnoczi
On Tue, Jun 12, 2018 at 07:26:25AM +0800, Jie Wang wrote: > if laio_init create linux_aio failed and return NULL, NULL pointer > dereference will occur when laio_attach_aio_context dereference > linux_aio in aio_get_linux_aio. Let's avoid it and report error. > > Signed-off-by: Jie Wang > --- >

[Qemu-devel] [PATCH v2] util/async: avoid NULL pointer dereference

2018-06-11 Thread Jie Wang
if laio_init create linux_aio failed and return NULL, NULL pointer dereference will occur when laio_attach_aio_context dereference linux_aio in aio_get_linux_aio. Let's avoid it and report error. Signed-off-by: Jie Wang --- block/file-posix.c | 19 +-- util/async.c | 5 +++

Re: [Qemu-devel] [PATCH v2] util/async: avoid NULL pointer dereference

2018-06-11 Thread Philippe Mathieu-Daudé
Hi Jie, On 06/11/2018 09:42 AM, Jie Wang wrote: > if laio_init create linux_aio failed and return NULL, NULL pointer > dereference will occur when laio_attach_aio_context dereference > linux_aio in aio_get_linux_aio. Let's avoid it and report error. > > Signed-off-by: Jie Wang > --- > block/fil

[Qemu-devel] [PATCH v2] util/async: avoid NULL pointer dereference

2018-06-11 Thread Jie Wang
if laio_init create linux_aio failed and return NULL, NULL pointer dereference will occur when laio_attach_aio_context dereference linux_aio in aio_get_linux_aio. Let's avoid it and report error. Signed-off-by: Jie Wang --- block/file-posix.c | 19 +-- util/async.c | 5 +++