Re: [Qemu-devel] [PATCH v2] tests/migration: Add source to PC boot block

2018-02-12 Thread Eric Blake
On 02/12/2018 09:07 AM, Dr. David Alan Gilbert wrote: Is xxd now considered a common enough tool for portable scripts? I've always liked xxd for manual use, but scripted with 'od'. This script isn't part of a normal build or make check or anything, so jumping through hoops to make it portable

Re: [Qemu-devel] [PATCH v2] tests/migration: Add source to PC boot block

2018-02-12 Thread Wei Huang
On 02/12/2018 09:07 AM, Dr. David Alan Gilbert wrote: > * Andrew Jones (drjo...@redhat.com) wrote: >> On Mon, Feb 05, 2018 at 06:18:46PM +, Dr. David Alan Gilbert (git) wrote: >>> diff --git a/tests/migration/rebuild-x86-bootblock.sh >>> b/tests/migration/rebuild-x86-bootblock.sh >>> new fil

Re: [Qemu-devel] [PATCH v2] tests/migration: Add source to PC boot block

2018-02-12 Thread Dr. David Alan Gilbert
* Andrew Jones (drjo...@redhat.com) wrote: > On Mon, Feb 05, 2018 at 06:18:46PM +, Dr. David Alan Gilbert (git) wrote: > > diff --git a/tests/migration/rebuild-x86-bootblock.sh > > b/tests/migration/rebuild-x86-bootblock.sh > > new file mode 100755 > > index 00..c40f025e1a > > --- /dev

Re: [Qemu-devel] [PATCH v2] tests/migration: Add source to PC boot block

2018-02-12 Thread Andrew Jones
On Mon, Feb 05, 2018 at 06:18:46PM +, Dr. David Alan Gilbert (git) wrote: > diff --git a/tests/migration/rebuild-x86-bootblock.sh > b/tests/migration/rebuild-x86-bootblock.sh > new file mode 100755 > index 00..c40f025e1a > --- /dev/null > +++ b/tests/migration/rebuild-x86-bootblock.sh

Re: [Qemu-devel] [PATCH v2] tests/migration: Add source to PC boot block

2018-02-09 Thread Wei Huang
On 02/05/2018 12:18 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The boot block used in the migration test is currently only > shipped as a hex (with the source in the git commit message), > change this to actually include the source. > > A script is added to re

[Qemu-devel] [PATCH v2] tests/migration: Add source to PC boot block

2018-02-05 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The boot block used in the migration test is currently only shipped as a hex (with the source in the git commit message), change this to actually include the source. A script is added to rebuild the header but the expectation is that the generated hex is shipped as