Re: [Qemu-devel] [PATCH v2] target-mips: fix broken MIPS16 and microMIPS

2014-09-29 Thread Maciej W. Rozycki
On Fri, 1 Aug 2014, Yongbok Kim wrote: > Ping! > Patch for v2.1.0 > > -Original Message- > From: Yongbok Kim > Sent: 01 July 2014 17:43 > To: qemu-devel@nongnu.org > Cc: aurel...@aurel32.net; Leon Alrae; Cristian Cuna; Yongbok Kim > Subject: [PATCH v2] target-mips: fix broken MIPS16 and

Re: [Qemu-devel] [PATCH v2] target-mips: fix broken MIPS16 and microMIPS

2014-09-22 Thread Leon Alrae
Hi Yongbok, For me this patch looks fine, just minor nitpicks: > if (blink > 0) { > int post_delay = insn_bytes; > int lowbit = !!(ctx->hflags & MIPS_HFLAG_M16); > > -if (opc != OPC_JALRC) > -post_delay += ((ctx->hflags & MIPS_HFLAG_BDS16) ? 2 : 4); >

Re: [Qemu-devel] [PATCH v2] target-mips: fix broken MIPS16 and microMIPS

2014-09-03 Thread James Hogan
On Tue, Jul 01, 2014 at 05:43:05PM +0100, Yongbok Kim wrote: > Commit 240ce26a broke MIPS16 and microMIPS support as it didn't > care those branches and jumps don't have delay slot in > MIPS16 and microMIPS. > > This patch introduces a new argument delayslot_size to the > gen_compute_branch() indi

Re: [Qemu-devel] [PATCH v2] target-mips: fix broken MIPS16 and microMIPS

2014-08-01 Thread Yongbok Kim
Ping! Patch for v2.1.0 -Original Message- From: Yongbok Kim Sent: 01 July 2014 17:43 To: qemu-devel@nongnu.org Cc: aurel...@aurel32.net; Leon Alrae; Cristian Cuna; Yongbok Kim Subject: [PATCH v2] target-mips: fix broken MIPS16 and microMIPS Commit 240ce26a broke MIPS16 and microMIPS supp

[Qemu-devel] [PATCH v2] target-mips: fix broken MIPS16 and microMIPS

2014-07-01 Thread Yongbok Kim
Commit 240ce26a broke MIPS16 and microMIPS support as it didn't care those branches and jumps don't have delay slot in MIPS16 and microMIPS. This patch introduces a new argument delayslot_size to the gen_compute_branch() indicating size of delay slot {0, 2, 4}. And the information is used to call