Re: [Qemu-devel] [PATCH v2] target-arm: add support for v8 AES instructions

2013-12-12 Thread Peter Maydell
On 5 December 2013 17:54, Ard Biesheuvel wrote: > This adds support for the AESE/AESD/AESMC/AESIMC instructions that > are available on some v8 implementations of Aarch32. > > Signed-off-by: Ard Biesheuvel I finally managed to get set up to compare this against a reference implementation, and co

Re: [Qemu-devel] [PATCH v2] target-arm: add support for v8 AES instructions

2013-12-10 Thread Ard Biesheuvel
On 10 December 2013 13:18, Aurelien Jarno wrote: > On Thu, Dec 05, 2013 at 06:54:38PM +0100, Ard Biesheuvel wrote: >> This adds support for the AESE/AESD/AESMC/AESIMC instructions that >> are available on some v8 implementations of Aarch32. >> [...] > All the tables to support AES instructions a

Re: [Qemu-devel] [PATCH v2] target-arm: add support for v8 AES instructions

2013-12-10 Thread Aurelien Jarno
On Thu, Dec 05, 2013 at 06:54:38PM +0100, Ard Biesheuvel wrote: > This adds support for the AESE/AESD/AESMC/AESIMC instructions that > are available on some v8 implementations of Aarch32. > > Signed-off-by: Ard Biesheuvel > --- > Changes since v1: > - refactored AES code: > * use precomputed lo

[Qemu-devel] [PATCH v2] target-arm: add support for v8 AES instructions

2013-12-05 Thread Ard Biesheuvel
This adds support for the AESE/AESD/AESMC/AESIMC instructions that are available on some v8 implementations of Aarch32. Signed-off-by: Ard Biesheuvel --- Changes since v1: - refactored AES code: * use precomputed lookup tables for AESMC and AESIMC * squash leaf functions add_sub_shift() and m