Re: [Qemu-devel] [PATCH v2] target-arm: Implement 'int' loglevel

2013-08-05 Thread Richard Henderson
On 08/05/2013 01:06 AM, Peter Maydell wrote: > The 'int' loglevel for recording interrupts and exceptions > requires support in the target-specific code. Implement > it for ARM. This improves debug logging in some situations > that were otherwise pretty opaque, such as when we fault > trying to exe

Re: [Qemu-devel] [PATCH v2] target-arm: Implement 'int' loglevel

2013-08-05 Thread Richard Henderson
On 08/05/2013 01:06 AM, Peter Maydell wrote: > +const char *exc = NULL; > + > +if (idx >= 0 && idx < ARRAY_SIZE(excnames)) { > +exc = excnames[idx]; > +} > +if (!exc) { > +exc = "unknown"; > +} Gah. Nevermind that last comment, I kne

Re: [Qemu-devel] [PATCH v2] target-arm: Implement 'int' loglevel

2013-08-05 Thread Richard Henderson
On 08/05/2013 01:06 AM, Peter Maydell wrote: > +const char *exc = NULL; > + > +if (idx >= 0 && idx < ARRAY_SIZE(excnames)) { > +exc = excnames[idx]; > +} > +if (!exc) { > +exc = "unknown"; > +} Silly test for null here. const char

[Qemu-devel] [PATCH v2] target-arm: Implement 'int' loglevel

2013-08-05 Thread Peter Maydell
The 'int' loglevel for recording interrupts and exceptions requires support in the target-specific code. Implement it for ARM. This improves debug logging in some situations that were otherwise pretty opaque, such as when we fault trying to execute at an exception vector address, which would otherw