Re: [Qemu-devel] [PATCH v2] target-arm: GIC: bug fixes for arm_gic.c

2012-12-20 Thread Daniel Sangorrin
On Sat, Dec 8, 2012 at 12:58 AM, Johannes Winter wrote: > On 07.12.2012 15:38, Peter Maydell wrote: > [...] > >> On 7 December 2012 14:31, Daniel Sangorrin >> wrote: > >> [...] > >>> In particular, I'm interested in helping to make current TrustZone >>> support by Johannes Winter >>> (https://git

Re: [Qemu-devel] [PATCH v2] target-arm: GIC: bug fixes for arm_gic.c

2012-12-07 Thread Johannes Winter
On 07.12.2012 15:38, Peter Maydell wrote: [...] On 7 December 2012 14:31, Daniel Sangorrin wrote: > [...] In particular, I'm interested in helping to make current TrustZone support by Johannes Winter (https://github.com/jowinter/qemu-trustzone) mainstream. I can contribute by testing it or add

Re: [Qemu-devel] [PATCH v2] target-arm: GIC: bug fixes for arm_gic.c

2012-12-07 Thread Peter Maydell
On 7 December 2012 14:31, Daniel Sangorrin wrote: > Thanks for your kind explanation. I will fix the patch and send it > again next Monday (hopefully I won't make any mistake this time). And > yes, I would like to collaborate with more patches in the future so it > might be good practice. OK, coo

Re: [Qemu-devel] [PATCH v2] target-arm: GIC: bug fixes for arm_gic.c

2012-12-07 Thread Daniel Sangorrin
Peter, Thanks for your kind explanation. I will fix the patch and send it again next Monday (hopefully I won't make any mistake this time). And yes, I would like to collaborate with more patches in the future so it might be good practice. In particular, I'm interested in helping to make current T

Re: [Qemu-devel] [PATCH v2] target-arm: GIC: bug fixes for arm_gic.c

2012-12-07 Thread Peter Maydell
On 7 December 2012 08:07, Daniel Sangorrin wrote: > Sorry, it seems that I did not understand the flow in the function > "hw/arm_gic.c:gic_dist_writeb()" and made some mistaken assumptions in > my previous patch. Please do not apply the previous patch, and apply > this one instead if you consider

[Qemu-devel] [PATCH v2] target-arm: GIC: bug fixes for arm_gic.c

2012-12-07 Thread Daniel Sangorrin
Sorry, it seems that I did not understand the flow in the function "hw/arm_gic.c:gic_dist_writeb()" and made some mistaken assumptions in my previous patch. Please do not apply the previous patch, and apply this one instead if you consider that it is correct. target-arm: fix bug in irq value on ar