Re: [Qemu-devel] [PATCH v2] target/arm: Vectorize USHL and SSHL

2019-06-07 Thread Peter Maydell
On Fri, 7 Jun 2019 at 16:40, Richard Henderson wrote: > > On 6/7/19 9:54 AM, Peter Maydell wrote: > > On Tue, 4 Jun 2019 at 00:22, Richard Henderson > > wrote: > >> > >> These instructions shift left or right depending on the sign > >> of the input, and 7 bits are significant to the shift. This

Re: [Qemu-devel] [PATCH v2] target/arm: Vectorize USHL and SSHL

2019-06-07 Thread Richard Henderson
On 6/7/19 9:54 AM, Peter Maydell wrote: > On Tue, 4 Jun 2019 at 00:22, Richard Henderson > wrote: >> >> These instructions shift left or right depending on the sign >> of the input, and 7 bits are significant to the shift. This >> requires several masks and selects in addition to the actual >> sh

Re: [Qemu-devel] [PATCH v2] target/arm: Vectorize USHL and SSHL

2019-06-07 Thread Peter Maydell
On Tue, 4 Jun 2019 at 00:22, Richard Henderson wrote: > > These instructions shift left or right depending on the sign > of the input, and 7 bits are significant to the shift. This > requires several masks and selects in addition to the actual > shifts to form the complete answer. > > That said,

Re: [Qemu-devel] [PATCH v2] target/arm: Vectorize USHL and SSHL

2019-06-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190603232209.20704-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2] target/arm: Vectorize USHL and SSHL Type: series Message-id

[Qemu-devel] [PATCH v2] target/arm: Vectorize USHL and SSHL

2019-06-03 Thread Richard Henderson
These instructions shift left or right depending on the sign of the input, and 7 bits are significant to the shift. This requires several masks and selects in addition to the actual shifts to form the complete answer. That said, the operation is still a small improvement even for two 64-bit eleme