Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-28 Thread Paolo Bonzini
On 27/04/2015 19:43, Peter Crosthwaite wrote: > To reduce verbosity, I suggest making object_set_link_property() a > visible API, then RYO link setters can call it surrounded by custom > behavior e.g: > > foo_object_set_bar_property(...) > { > pre_set_link_side_effects(); > object_set_li

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-28 Thread Peter Crosthwaite
On Mon, Apr 27, 2015 at 11:46 PM, Eric Auger wrote: > Hi Peter, > > On 04/27/2015 07:43 PM, Peter Crosthwaite wrote: >> On Mon, Apr 27, 2015 at 8:01 AM, Paolo Bonzini wrote: >>> >>> >>> On 27/04/2015 16:56, Eric Auger wrote: Peter, Paolo, After your feedbacks, I feel I need to spen

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-28 Thread Eric Auger
On 04/28/2015 08:57 AM, Peter Crosthwaite wrote: > On Mon, Apr 27, 2015 at 11:46 PM, Eric Auger wrote: >> Hi Peter, >> >> On 04/27/2015 07:43 PM, Peter Crosthwaite wrote: >>> On Mon, Apr 27, 2015 at 8:01 AM, Paolo Bonzini wrote: On 27/04/2015 16:56, Eric Auger wrote: > Peter, P

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-27 Thread Eric Auger
Hi Peter, On 04/27/2015 07:43 PM, Peter Crosthwaite wrote: > On Mon, Apr 27, 2015 at 8:01 AM, Paolo Bonzini wrote: >> >> >> On 27/04/2015 16:56, Eric Auger wrote: >>> Peter, Paolo, >>> >>> After your feedbacks, I feel I need to spend some more time on the >>> original check() track. I would prefe

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-27 Thread Peter Crosthwaite
On Mon, Apr 27, 2015 at 8:01 AM, Paolo Bonzini wrote: > > > On 27/04/2015 16:56, Eric Auger wrote: >> Peter, Paolo, >> >> After your feedbacks, I feel I need to spend some more time on the >> original check() track. I would prefer not to introduce any patch that >> will make issue in the future. >

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-27 Thread Eric Auger
On 04/27/2015 04:39 PM, Peter Crosthwaite wrote: > On Mon, Apr 27, 2015 at 6:37 AM, Paolo Bonzini wrote: >> >> >> On 27/04/2015 14:20, Eric Auger wrote: >>> On 04/27/2015 12:39 PM, Paolo Bonzini wrote: On 27/04/2015 10:26, Eric Auger wrote: >>> One of my long term goals is to tr

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-27 Thread Paolo Bonzini
On 27/04/2015 16:56, Eric Auger wrote: > Peter, Paolo, > > After your feedbacks, I feel I need to spend some more time on the > original check() track. I would prefer not to introduce any patch that > will make issue in the future. Peter, see the other threads between me and Eric. See in parti

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-27 Thread Peter Crosthwaite
On Mon, Apr 27, 2015 at 6:37 AM, Paolo Bonzini wrote: > > > On 27/04/2015 14:20, Eric Auger wrote: >> On 04/27/2015 12:39 PM, Paolo Bonzini wrote: >>> >>> >>> On 27/04/2015 10:26, Eric Auger wrote: >> One of my long term goals is to try and get rid of sysbus IRQ >> abstraction completely i

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-27 Thread Paolo Bonzini
On 27/04/2015 14:20, Eric Auger wrote: > On 04/27/2015 12:39 PM, Paolo Bonzini wrote: >> >> >> On 27/04/2015 10:26, Eric Auger wrote: > One of my long term goals is to try and get rid of sysbus IRQ > abstraction completely in favor of just qdev gpios. This means > features that apply

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-27 Thread Eric Auger
On 04/27/2015 12:39 PM, Paolo Bonzini wrote: > > > On 27/04/2015 10:26, Eric Auger wrote: One of my long term goals is to try and get rid of sysbus IRQ abstraction completely in favor of just qdev gpios. This means features that apply to GPIOs automatically apply to IRQs and vice >

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-27 Thread Paolo Bonzini
On 27/04/2015 10:26, Eric Auger wrote: >> > One of my long term goals is to try and get rid of sysbus IRQ >> > abstraction completely in favor of just qdev gpios. This means >> > features that apply to GPIOs automatically apply to IRQs and vice >> > versa. Can your notifier hook be pushed up to t

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-27 Thread Eric Auger
Hi Peter, On 04/27/2015 06:09 AM, Peter Crosthwaite wrote: > On Fri, Apr 24, 2015 at 5:39 AM, Eric Auger wrote: >> Add a new irq_routing_notifier notifier in the SysBusDeviceClass. This >> notifier, if populated, is called after sysbus_connect_irq. >> >> This mechanism is used to setup VFIO signal

Re: [Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-26 Thread Peter Crosthwaite
On Fri, Apr 24, 2015 at 5:39 AM, Eric Auger wrote: > Add a new irq_routing_notifier notifier in the SysBusDeviceClass. This > notifier, if populated, is called after sysbus_connect_irq. > > This mechanism is used to setup VFIO signaling once VFIO platform > devices get attached to their platform b

[Qemu-devel] [PATCH v2] sysbus: add irq_routing_notifier

2015-04-24 Thread Eric Auger
Add a new irq_routing_notifier notifier in the SysBusDeviceClass. This notifier, if populated, is called after sysbus_connect_irq. This mechanism is used to setup VFIO signaling once VFIO platform devices get attached to their platform bus, on a machine init done notifier. Signed-off-by: Eric Aug