Re: [Qemu-devel] [PATCH v2] scripts/qemu.py: allow to launch the VM without a monitor

2018-11-29 Thread Caio Carrara
Hi Wainer, Thanks for your reply. I pretty much agreed with most of it. I just added a comment about that new method that is not used anywere. On Thu, Nov 29, 2018 at 10:45:33AM -0200, Wainer dos Santos Moschetta wrote: > > On 11/26/2018 10:58 AM, Caio Carrara wrote: > > On Wed, Nov 21, 2018 at

Re: [Qemu-devel] [PATCH v2] scripts/qemu.py: allow to launch the VM without a monitor

2018-11-29 Thread Wainer dos Santos Moschetta
On 11/26/2018 10:58 AM, Caio Carrara wrote: On Wed, Nov 21, 2018 at 01:39:00PM -0500, Wainer dos Santos Moschetta wrote: QEMUMachine launches the VM with a monitor enabled, afterwards a qmp connection is attempted on _post_launch(). In case the QEMU process exits with an error, qmp.accept() re

Re: [Qemu-devel] [PATCH v2] scripts/qemu.py: allow to launch the VM without a monitor

2018-11-26 Thread Caio Carrara
On Wed, Nov 21, 2018 at 01:39:00PM -0500, Wainer dos Santos Moschetta wrote: > QEMUMachine launches the VM with a monitor enabled, afterwards > a qmp connection is attempted on _post_launch(). In case > the QEMU process exits with an error, qmp.accept() reaches > timeout and raises an exception. >