Re: [Qemu-devel] [PATCH v2] savevm: fix corruption in vmstate_subsection_load().

2011-06-09 Thread Paolo Bonzini
On 06/09/2011 02:48 PM, Kevin Wolf wrote: This means that subsections are silently ignored if the old version didn't have any subsection for the device. Wasn't it a fundamental point of the design of subsections that this would fail? Unfortunately you cannot have it both ways because the migrat

Re: [Qemu-devel] [PATCH v2] savevm: fix corruption in vmstate_subsection_load().

2011-06-09 Thread Kevin Wolf
Am 24.01.2011 10:30, schrieb Yoshiaki Tamura: > Although it's rare to happen in live migration, when the head of a > byte stream contains 0x05 which is the marker of subsection, the > loader gets corrupted because vmstate_subsection_load() continues even > the device doesn't require it. This patch

[Qemu-devel] [PATCH v2] savevm: fix corruption in vmstate_subsection_load().

2011-01-24 Thread Yoshiaki Tamura
Although it's rare to happen in live migration, when the head of a byte stream contains 0x05 which is the marker of subsection, the loader gets corrupted because vmstate_subsection_load() continues even the device doesn't require it. This patch adds a checker whether subsection is needed, and skip