Re: [Qemu-devel] [PATCH v2] s390: use FILE instead of QEMUFile for creating text file

2016-01-18 Thread Cornelia Huck
On Mon, 18 Jan 2016 09:50:32 + "Daniel P. Berrange" wrote: > On Fri, Jan 15, 2016 at 04:29:32PM -0700, Eric Blake wrote: > > On 01/12/2016 05:59 AM, Daniel P. Berrange wrote: > > > @@ -124,8 +120,14 @@ void qmp_dump_skeys(const char *filename, Error > > > **errp) > > > return; > >

Re: [Qemu-devel] [PATCH v2] s390: use FILE instead of QEMUFile for creating text file

2016-01-18 Thread Daniel P. Berrange
On Fri, Jan 15, 2016 at 04:29:32PM -0700, Eric Blake wrote: > On 01/12/2016 05:59 AM, Daniel P. Berrange wrote: > > The s390 skeys monitor command needs to write out a plain text > > file. Currently it is using the QEMUFile class for this, but > > work is ongoing to refactor QEMUFile and eliminate

Re: [Qemu-devel] [PATCH v2] s390: use FILE instead of QEMUFile for creating text file

2016-01-15 Thread Eric Blake
On 01/12/2016 05:59 AM, Daniel P. Berrange wrote: > The s390 skeys monitor command needs to write out a plain text > file. Currently it is using the QEMUFile class for this, but > work is ongoing to refactor QEMUFile and eliminate much code > related to it. The only feature qemu_fopen() gives over

[Qemu-devel] [PATCH v2] s390: use FILE instead of QEMUFile for creating text file

2016-01-12 Thread Daniel P. Berrange
The s390 skeys monitor command needs to write out a plain text file. Currently it is using the QEMUFile class for this, but work is ongoing to refactor QEMUFile and eliminate much code related to it. The only feature qemu_fopen() gives over fopen() is support for QEMU FD passing, but this can be ac