Re: [Qemu-devel] [PATCH v2] rules.mak: Rewrite unnest-vars

2014-05-23 Thread Paolo Bonzini
Il 23/05/2014 15:33, Fam Zheng ha scritto: On Fri, 05/23 15:22, Paolo Bonzini wrote: Just one question: +# fix-paths +# Usage: $(call fix-paths, obj_path, src_path, vars) +# Add prefix @obj_path to all objects in @vars, and add prefix @src_path to all +# directories in @vars. +define fix-paths

Re: [Qemu-devel] [PATCH v2] rules.mak: Rewrite unnest-vars

2014-05-23 Thread Fam Zheng
On Fri, 05/23 15:22, Paolo Bonzini wrote: > Just one question: > > >+# fix-paths > >+# Usage: $(call fix-paths, obj_path, src_path, vars) > >+# Add prefix @obj_path to all objects in @vars, and add prefix @src_path to > >all > >+# directories in @vars. > >+define fix-paths > >+$(foreach v,$3,

Re: [Qemu-devel] [PATCH v2] rules.mak: Rewrite unnest-vars

2014-05-23 Thread Paolo Bonzini
Just one question: +# fix-paths +# Usage: $(call fix-paths, obj_path, src_path, vars) +# Add prefix @obj_path to all objects in @vars, and add prefix @src_path to all +# directories in @vars. +define fix-paths +$(foreach v,$3, +$(foreach o,$($v), +$(if $($o-libs), +

Re: [Qemu-devel] [PATCH v2] rules.mak: Rewrite unnest-vars

2014-05-22 Thread Fam Zheng
On Tue, 05/13 21:24, Fam Zheng wrote: > The macro unnest-vars is the most important, complicated but hard to > track magic in QEMU's build system. > > Rewrite it in a (hopefully) clearer way, with more comments, to make it > easier to understand and maintain. > > Remove DSO_CFLAGS and module-objs

[Qemu-devel] [PATCH v2] rules.mak: Rewrite unnest-vars

2014-05-13 Thread Fam Zheng
The macro unnest-vars is the most important, complicated but hard to track magic in QEMU's build system. Rewrite it in a (hopefully) clearer way, with more comments, to make it easier to understand and maintain. Remove DSO_CFLAGS and module-objs-m that are not used. A bonus fix of this version i