Re: [Qemu-devel] [PATCH v2] rtl8139: implement 8139cp link status

2012-09-14 Thread Jason Wang
On 09/14/2012 03:30 PM, Stefan Hajnoczi wrote: On Fri, Sep 14, 2012 at 2:34 AM, Amos Kong wrote: On 13/09/12 20:29, Stefan Hajnoczi wrote: On Thu, Sep 13, 2012 at 9:51 AM, Amos Kong wrote: Regarding migration: do we migrate the NetClient->link_down field? If we only migrate the status registe

Re: [Qemu-devel] [PATCH v2] rtl8139: implement 8139cp link status

2012-09-14 Thread Stefan Hajnoczi
On Fri, Sep 14, 2012 at 2:34 AM, Amos Kong wrote: > On 13/09/12 20:29, Stefan Hajnoczi wrote: >> >> On Thu, Sep 13, 2012 at 9:51 AM, Amos Kong wrote: >> Regarding migration: do we migrate the NetClient->link_down field? If >> we only migrate the status register value then the link may actually >>

Re: [Qemu-devel] [PATCH v2] rtl8139: implement 8139cp link status

2012-09-13 Thread Amos Kong
On 13/09/12 20:29, Stefan Hajnoczi wrote: On Thu, Sep 13, 2012 at 9:51 AM, Amos Kong wrote: From: Jason Wang Add a link status chang callback and change the link status bit in BMSR & MSR accordingly. Tested in Linux/Windows guests. The link status bit of MediaStatus is infered from BasicMode

Re: [Qemu-devel] [PATCH v2] rtl8139: implement 8139cp link status

2012-09-13 Thread Stefan Hajnoczi
On Thu, Sep 13, 2012 at 9:51 AM, Amos Kong wrote: > From: Jason Wang > > Add a link status chang callback and change the link status bit in BMSR > & MSR accordingly. Tested in Linux/Windows guests. > > The link status bit of MediaStatus is infered from BasicModeStatus, > they are reverse. > > Sig

[Qemu-devel] [PATCH v2] rtl8139: implement 8139cp link status

2012-09-13 Thread Amos Kong
From: Jason Wang Add a link status chang callback and change the link status bit in BMSR & MSR accordingly. Tested in Linux/Windows guests. The link status bit of MediaStatus is infered from BasicModeStatus, they are reverse. Signed-off-by: Jason Wang Signed-off-by: Amos Kong --- v2: don't a