Re: [Qemu-devel] [PATCH v2] qom: object_property_add() performance improvement

2015-06-15 Thread Pavel Fedin
Hello! > 10 secs is still pretty brutal for machine init. Got any clues for > where the rest of the time is going? Every property_add_XXX() verifies that there are no duplicates. With this number of CPUs we still have thousands of properties on GIC object, so every new property still once wal

Re: [Qemu-devel] [PATCH v2] qom: object_property_add() performance improvement

2015-06-14 Thread Peter Crosthwaite
On Wed, Jun 10, 2015 at 12:51 AM, Pavel Fedin wrote: > The function originally behaves very badly when adding properties with "[*]" > suffix. Normally these are used for numbering IRQ pins. In order to find the > correct starting number the function started from zero and checked for > duplicates.

[Qemu-devel] [PATCH v2] qom: object_property_add() performance improvement

2015-06-10 Thread Pavel Fedin
The function originally behaves very badly when adding properties with "[*]" suffix. Normally these are used for numbering IRQ pins. In order to find the correct starting number the function started from zero and checked for duplicates. This takes incredibly long time with large number of CPUs beca