Re: [Qemu-devel] [PATCH v2] qmp: object-add: Validate class before creating object

2014-05-16 Thread Andreas Färber
Am 25.04.2014 21:16, schrieb Eduardo Habkost: > On Fri, Apr 25, 2014 at 08:42:59PM +0200, Andreas Färber wrote: >> Am 25.04.2014 20:02, schrieb Luiz Capitulino: >>> On Fri, 25 Apr 2014 17:57:12 +0200 >>> Andreas Färber wrote: Am 25.04.2014 17:12, schrieb Luiz Capitulino: > On Wed, 16 Apr

Re: [Qemu-devel] [PATCH v2] qmp: object-add: Validate class before creating object

2014-04-25 Thread Eduardo Habkost
On Fri, Apr 25, 2014 at 08:42:59PM +0200, Andreas Färber wrote: > Am 25.04.2014 20:02, schrieb Luiz Capitulino: > > On Fri, 25 Apr 2014 17:57:12 +0200 > > Andreas Färber wrote: > >> Am 25.04.2014 17:12, schrieb Luiz Capitulino: > >>> On Wed, 16 Apr 2014 14:39:38 -0300 > >>> Eduardo Habkost wrote:

Re: [Qemu-devel] [PATCH v2] qmp: object-add: Validate class before creating object

2014-04-25 Thread Andreas Färber
Am 25.04.2014 20:02, schrieb Luiz Capitulino: > On Fri, 25 Apr 2014 17:57:12 +0200 > Andreas Färber wrote: >> Am 25.04.2014 17:12, schrieb Luiz Capitulino: >>> On Wed, 16 Apr 2014 14:39:38 -0300 >>> Eduardo Habkost wrote: >>> Currently it is very easy to crash QEMU by issuing an object-add c

Re: [Qemu-devel] [PATCH v2] qmp: object-add: Validate class before creating object

2014-04-25 Thread Luiz Capitulino
On Fri, 25 Apr 2014 17:57:12 +0200 Andreas Färber wrote: > Am 25.04.2014 17:12, schrieb Luiz Capitulino: > > On Wed, 16 Apr 2014 14:39:38 -0300 > > Eduardo Habkost wrote: > > > >> Currently it is very easy to crash QEMU by issuing an object-add command > >> using an abstract class or a class th

Re: [Qemu-devel] [PATCH v2] qmp: object-add: Validate class before creating object

2014-04-25 Thread Andreas Färber
Am 25.04.2014 17:12, schrieb Luiz Capitulino: > On Wed, 16 Apr 2014 14:39:38 -0300 > Eduardo Habkost wrote: > >> Currently it is very easy to crash QEMU by issuing an object-add command >> using an abstract class or a class that doesn't support >> TYPE_USER_CREATABLE as parameter. >> >> Example:

Re: [Qemu-devel] [PATCH v2] qmp: object-add: Validate class before creating object

2014-04-25 Thread Luiz Capitulino
On Wed, 16 Apr 2014 14:39:38 -0300 Eduardo Habkost wrote: > Currently it is very easy to crash QEMU by issuing an object-add command > using an abstract class or a class that doesn't support > TYPE_USER_CREATABLE as parameter. > > Example: with the following QMP command: > > (QEMU) object-a

Re: [Qemu-devel] [PATCH v2] qmp: object-add: Validate class before creating object

2014-04-16 Thread Matthew Rosato
On 04/16/2014 01:39 PM, Eduardo Habkost wrote: > Currently it is very easy to crash QEMU by issuing an object-add command > using an abstract class or a class that doesn't support > TYPE_USER_CREATABLE as parameter. > > Example: with the following QMP command: > > (QEMU) object-add qom-type=c

[Qemu-devel] [PATCH v2] qmp: object-add: Validate class before creating object

2014-04-16 Thread Eduardo Habkost
Currently it is very easy to crash QEMU by issuing an object-add command using an abstract class or a class that doesn't support TYPE_USER_CREATABLE as parameter. Example: with the following QMP command: (QEMU) object-add qom-type=cpu id=foo QEMU aborts at: ERROR:qom/object.c:335:object