Re: [Qemu-devel] [PATCH v2] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-30 Thread Stefan Hajnoczi
On Mon, Jan 21, 2013 at 12:03:47PM +, Peter Maydell wrote: > Remove an unnecessary mutual inclusion loop between qemu-pixman.h and > console.h, since the former was only including the latter for > 'PixelFormat*', which can be provided by typedefs.h. This requires a > minor adjustment to the fi

Re: [Qemu-devel] [PATCH v2] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-28 Thread Peter Maydell
Ping: Stefan, are you going to take this via -trivial as Gerd suggests? [patchwork url: http://patchwork.ozlabs.org/patch/214114/ ] thanks -- PMM On 21 January 2013 17:14, Gerd Hoffmann wrote: > On 01/21/13 15:19, Gerd Hoffmann wrote: >>> Stefan: I've made the obvious change to fix the spice co

Re: [Qemu-devel] [PATCH v2] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-21 Thread Gerd Hoffmann
On 01/21/13 15:19, Gerd Hoffmann wrote: >> Stefan: I've made the obvious change to fix the spice compile issue, >> but none of my systems have a new enough spice-protocol/spice-server >> to allow me to configure with spice enabled. I'd appreciate it if >> you could check it does indeed compile OK n

Re: [Qemu-devel] [PATCH v2] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-21 Thread Gerd Hoffmann
> Stefan: I've made the obvious change to fix the spice compile issue, > but none of my systems have a new enough spice-protocol/spice-server > to allow me to configure with spice enabled. I'd appreciate it if > you could check it does indeed compile OK now... I'll run this through the buildbot ..

Re: [Qemu-devel] [PATCH v2] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-21 Thread Peter Maydell
On 21 January 2013 14:19, Gerd Hoffmann wrote: >> Stefan: I've made the obvious change to fix the spice compile issue, >> but none of my systems have a new enough spice-protocol/spice-server >> to allow me to configure with spice enabled. I'd appreciate it if >> you could check it does indeed comp

[Qemu-devel] [PATCH v2] qemu-pixman.h: Avoid mutual inclusion loop with console.h

2013-01-21 Thread Peter Maydell
Remove an unnecessary mutual inclusion loop between qemu-pixman.h and console.h, since the former was only including the latter for 'PixelFormat*', which can be provided by typedefs.h. This requires a minor adjustment to the files which included qemu-pixman.h, since they were relying on it implici