Re: [Qemu-devel] [PATCH v2] qemu-img: initialize MapEntry object

2016-02-12 Thread Kevin Wolf
Am 05.02.2016 um 20:56 hat Eric Blake geschrieben: > On 02/05/2016 11:12 AM, John Snow wrote: > > Commit 16b0d555 introduced an issue where we are not initializing > > has_filename for the 'next' MapEntry object, which leads to interesting > > errors in Valgrind and Clang -fsanitize=undefined both.

Re: [Qemu-devel] [PATCH v2] qemu-img: initialize MapEntry object

2016-02-05 Thread Eric Blake
On 02/05/2016 11:12 AM, John Snow wrote: > Commit 16b0d555 introduced an issue where we are not initializing > has_filename for the 'next' MapEntry object, which leads to interesting > errors in Valgrind and Clang -fsanitize=undefined both. grammar: errors in both Valgrind and Clang -fsanitize=un

[Qemu-devel] [PATCH v2] qemu-img: initialize MapEntry object

2016-02-05 Thread John Snow
Commit 16b0d555 introduced an issue where we are not initializing has_filename for the 'next' MapEntry object, which leads to interesting errors in Valgrind and Clang -fsanitize=undefined both. Zero the stack object at allocation AND make sure the utility to populate the fields properly marks has_