Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-02-05 Thread Markus Armbruster
Peter Crosthwaite writes: > On Tue, Feb 4, 2014 at 7:28 PM, Markus Armbruster wrote: >> Markus Armbruster writes: >> >>> Peter Crosthwaite writes: >>> On Wed, Jan 8, 2014 at 11:47 PM, Paolo Bonzini wrote: > Il 08/01/2014 14:40, Andreas Färber ha scritto: >> > Either you fix "info

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-02-04 Thread Peter Crosthwaite
On Tue, Feb 4, 2014 at 7:28 PM, Markus Armbruster wrote: > Markus Armbruster writes: > >> Peter Crosthwaite writes: >> >>> On Wed, Jan 8, 2014 at 11:47 PM, Paolo Bonzini wrote: Il 08/01/2014 14:40, Andreas Färber ha scritto: > > Either you fix "info qtree" to cope with your change to t

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-02-04 Thread Markus Armbruster
Markus Armbruster writes: > Peter Crosthwaite writes: > >> On Wed, Jan 8, 2014 at 11:47 PM, Paolo Bonzini wrote: >>> Il 08/01/2014 14:40, Andreas Färber ha scritto: > Either you fix "info qtree" to cope with your change to the device > graph, or the change needs to be reverted until s

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-10 Thread Markus Armbruster
Peter Crosthwaite writes: > On Wed, Jan 8, 2014 at 11:47 PM, Paolo Bonzini wrote: >> Il 08/01/2014 14:40, Andreas Färber ha scritto: >>> > Either you fix "info qtree" to cope with your change to the device >>> > graph, or the change needs to be reverted until somebody fixes it or it >>> > goes a

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-09 Thread Peter Crosthwaite
On Wed, Jan 8, 2014 at 11:47 PM, Paolo Bonzini wrote: > Il 08/01/2014 14:40, Andreas Färber ha scritto: >> > Either you fix "info qtree" to cope with your change to the device >> > graph, or the change needs to be reverted until somebody fixes it or it >> > goes away. >> Sharing a backtrace would

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Markus Armbruster
Paolo Bonzini writes: > Il 08/01/2014 15:35, Markus Armbruster ha scritto: >> Paolo Bonzini writes: >> >>> Leaving only those that will be affected by the patch: >> >> You omitted akita, borzoi, connex, mainstone, nuri, smdkc210, spitz, >> terrier, tosa, verdex, z2, s390-virtio. Why won't the

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 15:35, Markus Armbruster ha scritto: > Paolo Bonzini writes: > >> Leaving only those that will be affected by the patch: > > You omitted akita, borzoi, connex, mainstone, nuri, smdkc210, spitz, > terrier, tosa, verdex, z2, s390-virtio. Why won't they be affected? Because the dup

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Markus Armbruster
Paolo Bonzini writes: > Leaving only those that will be affected by the patch: You omitted akita, borzoi, connex, mainstone, nuri, smdkc210, spitz, terrier, tosa, verdex, z2, s390-virtio. Why won't they be affected? You also omitted the machines that I can't get to start, but I'm not overly wo

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 14:53, Andreas Färber ha scritto: > Am 08.01.2014 12:02, schrieb Paolo Bonzini: >> Il 08/01/2014 04:07, Peter Crosthwaite ha scritto: > The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbus, > 2013-06-18). Should probably be reverted. > >>> Prefer not,

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Paolo Bonzini
Leaving only those that will be affected by the patch: Il 07/01/2014 18:34, Markus Armbruster ha scritto: > target machine bus id times > aarch64 n800i2c-bus.0 2 > aarch64 n810i2c-bus.0 2 > arm n8

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Andreas Färber
Am 08.01.2014 12:02, schrieb Paolo Bonzini: > Il 08/01/2014 04:07, Peter Crosthwaite ha scritto: The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbus, 2013-06-18). Should probably be reverted. >> Prefer not, under no reasonable definition is NAND a sysbus device.

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 14:40, Andreas Färber ha scritto: > > Either you fix "info qtree" to cope with your change to the device > > graph, or the change needs to be reverted until somebody fixes it or it > > goes away. > Sharing a backtrace would be a start, rather than just throwing around > the word "cras

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Andreas Färber
Am 08.01.2014 09:13, schrieb Markus Armbruster: > Peter Crosthwaite writes: > >> On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini wrote: >>> Il 07/01/2014 16:12, Markus Armbruster ha scritto: aarch64 akita info qtree crashes aarch64 borzoi info qtree cra

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Paolo Bonzini
Il 08/01/2014 04:07, Peter Crosthwaite ha scritto: >> > The crash is because of commit 7426aa7 (nand: Don't inherit from Sysbus, >> > 2013-06-18). Should probably be reverted. >> > > Prefer not, under no reasonable definition is NAND a sysbus device. > Whats the real problem here? What is TYPE_SY

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Peter Maydell
On 8 January 2014 04:24, Andreas Färber wrote: > P.S. PMM, reading aarch64 above in the context of machines, I don't see > a single check-qtest-aarch64-y line in tests/Makefile! Please enable > qom-test if qemu-system-aarch64 is already available. Thought you just > said it would be linux-user onl

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Peter Crosthwaite
On Wed, Jan 8, 2014 at 6:13 PM, Markus Armbruster wrote: > > Peter Crosthwaite writes: > > > On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini wrote: > >> Il 07/01/2014 16:12, Markus Armbruster ha scritto: > >>> aarch64 akita info qtree crashes > >>> aarch64 borzoi

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Markus Armbruster
Peter Crosthwaite writes: > On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini wrote: >> Il 07/01/2014 16:12, Markus Armbruster ha scritto: >>> aarch64 akita info qtree crashes >>> aarch64 borzoi info qtree crashes >>> aarch64 spitz info qtree cras

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-08 Thread Markus Armbruster
Andreas Färber writes: > Am 08.01.2014 04:07, schrieb Peter Crosthwaite: >> On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini wrote: >>> Il 07/01/2014 16:12, Markus Armbruster ha scritto: aarch64 akita info qtree crashes aarch64 borzoi info qtree crashes

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-07 Thread Andreas Färber
Am 08.01.2014 04:07, schrieb Peter Crosthwaite: > On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini wrote: >> Il 07/01/2014 16:12, Markus Armbruster ha scritto: >>> aarch64 akita info qtree crashes >>> aarch64 borzoi info qtree crashes >>> aarch64 spitz

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-07 Thread Peter Crosthwaite
On Wed, Jan 8, 2014 at 2:59 AM, Paolo Bonzini wrote: > Il 07/01/2014 16:12, Markus Armbruster ha scritto: >> aarch64 akita info qtree crashes >> aarch64 borzoi info qtree crashes >> aarch64 spitz info qtree crashes >> aarch64 terrier

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-07 Thread Markus Armbruster
Paolo Bonzini writes: > Il 07/01/2014 16:12, Markus Armbruster ha scritto: >> aarch64 akita info qtree crashes >> aarch64 borzoi info qtree crashes >> aarch64 spitz info qtree crashes >> aarch64 terrier info qtree crashes >>

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-07 Thread Paolo Bonzini
Il 07/01/2014 16:12, Markus Armbruster ha scritto: > aarch64 akita info qtree crashes > aarch64 borzoi info qtree crashes > aarch64 spitz info qtree crashes > aarch64 terrier info qtree crashes > aarch64 tosain

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2014-01-07 Thread Markus Armbruster
Paolo Bonzini writes: > Il 21/12/2013 11:42, Markus Armbruster ha scritto: >> Suggest to add: ", killing migration." > > Not good. But perhaps we can give a reason for this 2.0 thing. > > It is certainly nice to schedule incompatible changes for obscure > machine types every 2 years. > >> Which

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2013-12-22 Thread Paolo Bonzini
Il 21/12/2013 11:42, Markus Armbruster ha scritto: > Suggest to add: ", killing migration." Not good. But perhaps we can give a reason for this 2.0 thing. It is certainly nice to schedule incompatible changes for obscure machine types every 2 years. > Which boards are affected? Should be liste

Re: [Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2013-12-21 Thread Markus Armbruster
Alexander Graf writes: > When we have 2 separate qdev devices that both create a qbus of the > same type without specifying a bus name or device name, we end up > with two buses of the same name, such as ide.0 on the Mac machines: > > dev: macio-ide, id "" > bus: ide.0 > type IDE >

[Qemu-devel] [PATCH v2] qdev: Keep global allocation counter per bus

2013-12-19 Thread Alexander Graf
When we have 2 separate qdev devices that both create a qbus of the same type without specifying a bus name or device name, we end up with two buses of the same name, such as ide.0 on the Mac machines: dev: macio-ide, id "" bus: ide.0 type IDE dev: macio-ide, id "" bus: ide.0