Re: [Qemu-devel] [PATCH v2] qapi: Reduce Makefile boilerplate

2018-11-16 Thread Eric Blake
On 11/16/18 4:26 AM, Daniel P. Berrangé wrote: Makefile | 192 ++ Makefile.objs | 75 ++-- 2 files changed, 30 insertions(+), 237 deletions(-) Reviewed-by: Daniel P. Berrangé Though I'd also suggest .gitignore is updat

Re: [Qemu-devel] [PATCH v2] qapi: Reduce Makefile boilerplate

2018-11-16 Thread Daniel P . Berrangé
On Thu, Nov 15, 2018 at 04:50:52PM -0600, Eric Blake wrote: > Adding a new qapi module requires some rather tedious repetition to > wire it into Makefile and Makefile.objs. Add some indirection by > taking advantage of GNU Make string processing to expand a list > of module names into all the requi

Re: [Qemu-devel] [PATCH v2] qapi: Reduce Makefile boilerplate

2018-11-16 Thread Markus Armbruster
Eric Blake writes: > Adding a new qapi module requires some rather tedious repetition to > wire it into Makefile and Makefile.objs. Add some indirection by > taking advantage of GNU Make string processing to expand a list > of module names into all the required artifacts, so that future > additio

Re: [Qemu-devel] [PATCH v2] qapi: Reduce Makefile boilerplate

2018-11-15 Thread Paolo Bonzini
On 15/11/2018 23:50, Eric Blake wrote: > Adding a new qapi module requires some rather tedious repetition to > wire it into Makefile and Makefile.objs. Add some indirection by > taking advantage of GNU Make string processing to expand a list > of module names into all the required artifacts, so tha

[Qemu-devel] [PATCH v2] qapi: Reduce Makefile boilerplate

2018-11-15 Thread Eric Blake
Adding a new qapi module requires some rather tedious repetition to wire it into Makefile and Makefile.objs. Add some indirection by taking advantage of GNU Make string processing to expand a list of module names into all the required artifacts, so that future additions of a new module need only to