Re: [Qemu-devel] [PATCH v2] net: Fix hotplug with pci_add

2010-06-15 Thread Amit Shah
On (Wed) Jun 09 2010 [15:28:11], Amit Shah wrote: > > Let me rephrase: Behavior changes for -net types without an init() > > method. The only one without an init() method is "none". Before, > > net_client_init() succeeded for it. Now it fails. What's the impact of > > that change? And why does

Re: [Qemu-devel] [PATCH v2] net: Fix hotplug with pci_add

2010-06-09 Thread Markus Armbruster
Amit Shah writes: > On (Wed) Jun 09 2010 [08:37:26], Markus Armbruster wrote: >> Amit Shah writes: >> >> > On (Tue) Jun 08 2010 [18:33:00], Markus Armbruster wrote: >> >> Amit Shah writes: >> >> >> >> > The correct model type wasn't getting added when hotplugging nics with >> >> > pci_add. >>

Re: [Qemu-devel] [PATCH v2] net: Fix hotplug with pci_add

2010-06-09 Thread Amit Shah
On (Wed) Jun 09 2010 [08:37:26], Markus Armbruster wrote: > Amit Shah writes: > > > On (Tue) Jun 08 2010 [18:33:00], Markus Armbruster wrote: > >> Amit Shah writes: > >> > >> > The correct model type wasn't getting added when hotplugging nics with > >> > pci_add. > >> > > >> > Testcase: start V

Re: [Qemu-devel] [PATCH v2] net: Fix hotplug with pci_add

2010-06-08 Thread Markus Armbruster
Amit Shah writes: > On (Tue) Jun 08 2010 [18:33:00], Markus Armbruster wrote: >> Amit Shah writes: >> >> > The correct model type wasn't getting added when hotplugging nics with >> > pci_add. >> > >> > Testcase: start VM with default nic type. In the qemu_monitor: >> > >> > (qemu) pci_add auto

Re: [Qemu-devel] [PATCH v2] net: Fix hotplug with pci_add

2010-06-08 Thread Amit Shah
On (Tue) Jun 08 2010 [18:33:00], Markus Armbruster wrote: > Amit Shah writes: > > > The correct model type wasn't getting added when hotplugging nics with > > pci_add. > > > > Testcase: start VM with default nic type. In the qemu_monitor: > > > > (qemu) pci_add auto nic model=virtio > > > > This

Re: [Qemu-devel] [PATCH v2] net: Fix hotplug with pci_add

2010-06-08 Thread Markus Armbruster
Amit Shah writes: > The correct model type wasn't getting added when hotplugging nics with > pci_add. > > Testcase: start VM with default nic type. In the qemu_monitor: > > (qemu) pci_add auto nic model=virtio > > This results in a nic hot-plug of the same nic type as the default. Works fine for

[Qemu-devel] [PATCH v2] net: Fix hotplug with pci_add

2010-06-08 Thread Amit Shah
The correct model type wasn't getting added when hotplugging nics with pci_add. Testcase: start VM with default nic type. In the qemu_monitor: (qemu) pci_add auto nic model=virtio This results in a nic hot-plug of the same nic type as the default. This was broken in 5294e2c774f120e10b44652ac143