Re: [Qemu-devel] [PATCH v2] net/pcnet: modernise PCNET_DEBUG

2017-06-09 Thread Philippe Mathieu-Daudé
On 06/09/2017 01:04 PM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: Ensure the format strings are always preprocessed, so any problem get reported. Signed-off-by: Philippe Mathieu-Daudé --- v2: Addressed review feedback from Alex Bennée No changes in *printf() calls but using qem

Re: [Qemu-devel] [PATCH v2] net/pcnet: modernise PCNET_DEBUG

2017-06-09 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Ensure the format strings are always preprocessed, so any problem get > reported. > > Signed-off-by: Philippe Mathieu-Daudé > --- > > v2: Addressed review feedback from Alex Bennée > No changes in *printf() calls but using qemu_log_mask() is an option. > >

[Qemu-devel] [PATCH v2] net/pcnet: modernise PCNET_DEBUG

2017-06-09 Thread Philippe Mathieu-Daudé
Ensure the format strings are always preprocessed, so any problem get reported. Signed-off-by: Philippe Mathieu-Daudé --- v2: Addressed review feedback from Alex Bennée No changes in *printf() calls but using qemu_log_mask() is an option. hw/net/pcnet-pci.c | 13 hw/net/pcnet.c |