Re: [Qemu-devel] [PATCH v2] more check for replaced node

2015-07-16 Thread Wen Congyang
On 07/15/2015 11:05 AM, Fam Zheng wrote: > On Wed, 07/15 09:41, Wen Congyang wrote: >> We use mirror+replace to fix quorum's broken child. bs/s->common.bs >> is quorum, and to_replace is the broken child. The new child is target_bs. >> Without this patch, the replace node can be any node, and it ca

Re: [Qemu-devel] [PATCH v2] more check for replaced node

2015-07-16 Thread Wen Congyang
On 07/16/2015 09:36 PM, Stefan Hajnoczi wrote: > On Wed, Jul 15, 2015 at 11:22:52AM +0800, Wen Congyang wrote: >> On 07/15/2015 11:05 AM, Fam Zheng wrote: >>> On Wed, 07/15 09:41, Wen Congyang wrote: We use mirror+replace to fix quorum's broken child. bs/s->common.bs is quorum, and to_rep

Re: [Qemu-devel] [PATCH v2] more check for replaced node

2015-07-16 Thread Stefan Hajnoczi
On Wed, Jul 15, 2015 at 11:22:52AM +0800, Wen Congyang wrote: > On 07/15/2015 11:05 AM, Fam Zheng wrote: > > On Wed, 07/15 09:41, Wen Congyang wrote: > >> We use mirror+replace to fix quorum's broken child. bs/s->common.bs > >> is quorum, and to_replace is the broken child. The new child is target_

Re: [Qemu-devel] [PATCH v2] more check for replaced node

2015-07-14 Thread Wen Congyang
On 07/15/2015 11:05 AM, Fam Zheng wrote: > On Wed, 07/15 09:41, Wen Congyang wrote: >> We use mirror+replace to fix quorum's broken child. bs/s->common.bs >> is quorum, and to_replace is the broken child. The new child is target_bs. >> Without this patch, the replace node can be any node, and it ca

Re: [Qemu-devel] [PATCH v2] more check for replaced node

2015-07-14 Thread Fam Zheng
On Wed, 07/15 09:41, Wen Congyang wrote: > We use mirror+replace to fix quorum's broken child. bs/s->common.bs > is quorum, and to_replace is the broken child. The new child is target_bs. > Without this patch, the replace node can be any node, and it can be > top BDS with BB, or another quorum's ch

[Qemu-devel] [PATCH v2] more check for replaced node

2015-07-14 Thread Wen Congyang
We use mirror+replace to fix quorum's broken child. bs/s->common.bs is quorum, and to_replace is the broken child. The new child is target_bs. Without this patch, the replace node can be any node, and it can be top BDS with BB, or another quorum's child. We just check if the broken child is part of