Re: [Qemu-devel] [PATCH v2] microblaze: fix memory leak

2015-04-29 Thread Michael Tokarev
05.03.2015 06:05, arei.gong...@huawei.com wrote: > From: Gonglei > > When not assign a -dtb argument, the variable dtb_filename > storage returned from qemu_find_file(), which should be freed > after use. Alternatively we define a local variable filename, > with 'char *' type, free after use. Ac

Re: [Qemu-devel] [PATCH v2] microblaze: fix memory leak

2015-04-29 Thread Peter Crosthwaite
On Wed, Mar 4, 2015 at 7:05 PM, wrote: > From: Gonglei > > When not assign a -dtb argument, the variable dtb_filename > storage returned from qemu_find_file(), which should be freed > after use. Alternatively we define a local variable filename, > with 'char *' type, free after use. > > Cc: Mich

Re: [Qemu-devel] [PATCH v2] microblaze: fix memory leak

2015-04-28 Thread Gonglei
On 2015/3/30 1:09, Michael Tokarev wrote: > 28.03.2015 10:46, Gonglei wrote: > [] >>> Can this go through -trivial? >>> >> It's ok, but I don't know if -trivial branch maintainer has a plan to send a >> pull request >> for rc2. > > I do have plan to send a pull request, but this thing is ugly. T

Re: [Qemu-devel] [PATCH v2] microblaze: fix memory leak

2015-03-29 Thread Michael Tokarev
28.03.2015 10:46, Gonglei wrote: [] >> Can this go through -trivial? >> > It's ok, but I don't know if -trivial branch maintainer has a plan to send a > pull request > for rc2. I do have plan to send a pull request, but this thing is ugly. The original code is ugly, and your patch does not make

Re: [Qemu-devel] [PATCH v2] microblaze: fix memory leak

2015-03-28 Thread Gonglei
On 2015/3/28 15:31, Edgar E. Iglesias wrote: > On 28/03/2015 12:38 pm, "Gonglei" wrote: >> >> Hi, >> >>Ping again... Can this patch be a raw stuff for rc2 ? > > Looks good to me, thanks. > > Reviewed-by: Edgar E. Iglesias > Thanks :) > Can this go through -trivial? > It's ok, but I don't

Re: [Qemu-devel] [PATCH v2] microblaze: fix memory leak

2015-03-28 Thread Edgar E. Iglesias
On 28/03/2015 12:38 pm, "Gonglei" wrote: > > Hi, > >Ping again... Can this patch be a raw stuff for rc2 ? Looks good to me, thanks. Reviewed-by: Edgar E. Iglesias Can this go through -trivial? Cheers, Edgar > > Regards, > Gonglei > > On 2015/3/17 15:15, Gonglei wrote: > > On 2015/3/5 11

Re: [Qemu-devel] [PATCH v2] microblaze: fix memory leak

2015-03-27 Thread Max Filippov
On Thu, Mar 5, 2015 at 6:05 AM, wrote: > From: Gonglei > > When not assign a -dtb argument, the variable dtb_filename > storage returned from qemu_find_file(), which should be freed > after use. Alternatively we define a local variable filename, > with 'char *' type, free after use. > > Cc: Mich

Re: [Qemu-devel] [PATCH v2] microblaze: fix memory leak

2015-03-27 Thread Gonglei
Hi, Ping again... Can this patch be a raw stuff for rc2 ? Regards, Gonglei On 2015/3/17 15:15, Gonglei wrote: > On 2015/3/5 11:05, arei.gong...@huawei.com wrote: >> From: Gonglei >> >> When not assign a -dtb argument, the variable dtb_filename >> storage returned from qemu_find_file(), whic

Re: [Qemu-devel] [PATCH v2] microblaze: fix memory leak

2015-03-17 Thread Gonglei
On 2015/3/5 11:05, arei.gong...@huawei.com wrote: > From: Gonglei > > When not assign a -dtb argument, the variable dtb_filename > storage returned from qemu_find_file(), which should be freed > after use. Alternatively we define a local variable filename, > with 'char *' type, free after use. >

[Qemu-devel] [PATCH v2] microblaze: fix memory leak

2015-03-04 Thread arei.gonglei
From: Gonglei When not assign a -dtb argument, the variable dtb_filename storage returned from qemu_find_file(), which should be freed after use. Alternatively we define a local variable filename, with 'char *' type, free after use. Cc: Michael Tokarev Cc: Edgar E. Iglesias Signed-off-by: Gong