Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments

2017-03-10 Thread Paolo Bonzini
On 09/03/2017 17:38, Dr. David Alan Gilbert wrote: > It is used by all of the _ram specific functions, so it seemed worth > including the comment. It's internal though. memory.c users never use it in a way that creates a RAMBlock. > (I also see it's used in some of the boards but I don't under

Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments

2017-03-09 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 09/03/2017 17:13, Dr. David Alan Gilbert wrote: > >>> + * @name: Region name, becomes part of RAMBlock name used in migration > >>> stream > >>> + *must be unique within any device > >>> * @size: size of the region; any subregions b

Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments

2017-03-09 Thread Paolo Bonzini
On 09/03/2017 17:13, Dr. David Alan Gilbert wrote: >>> + * @name: Region name, becomes part of RAMBlock name used in migration >>> stream >>> + *must be unique within any device >>> * @size: size of the region; any subregions beyond this size will be >>> clipped >>> */ >>> void mem

Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments

2017-03-09 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 09/03/2017 16:27, Dr. David Alan Gilbert (git) wrote: > > + * @name: Region name, becomes part of RAMBlock name used in migration > > stream > > + *must be unique within any device > > * @size: size of the region; any subregions bey

Re: [Qemu-devel] [PATCH v2] memory_region: Fix name comments

2017-03-09 Thread Paolo Bonzini
On 09/03/2017 16:27, Dr. David Alan Gilbert (git) wrote: > + * @name: Region name, becomes part of RAMBlock name used in migration stream > + *must be unique within any device > * @size: size of the region; any subregions beyond this size will be clipped > */ > void memory_region_ini

[Qemu-devel] [PATCH v2] memory_region: Fix name comments

2017-03-09 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The 'name' parameter to memory_region_init_* had been marked as debug only, however vmstate_region_ram uses it as a parameter to qemu_ram_set_idstr to set RAMBlock names and these form part of the migration stream. Signed-off-by: Dr. David Alan Gilbert --- v2 Re