Re: [Qemu-devel] [PATCH v2] mainstone: Fix duplicate array values for key 'space'

2013-12-22 Thread Peter Maydell
On 22 December 2013 19:01, Stefan Weil wrote: > > v2: Address Peter Maydell's suggestions: > * Use first alternative, so there is no change of behaviour No, I said that the compiler picked the last of the two, (5,3) > [0x39] = {5,2}, /* space */ > -[0x39] = {5,3}, /* space */ > -

[Qemu-devel] [PATCH v2] mainstone: Fix duplicate array values for key 'space'

2013-12-22 Thread Stefan Weil
cgcc reported a duplicate initialisation. Mainstone includes a matrix keyboard where two different positions map to 'space'. QEMU uses the reversed mapping and does not map 'space' to two different matrix positions. Some other keys are either missing or might be mapped wrongly (cf. Linux kernel c