Re: [Qemu-devel] [PATCH v2] lsi53c895a: check message length value is valid

2018-10-30 Thread P J P
+-- On Tue, 30 Oct 2018, Paolo Bonzini wrote --+ | | Reviewed-by: Paolo Bonzini | | with one change below: | | > +if ((s->sstat1 & PHASE_MASK) == PHASE_MI) { | > +assert(s->msg_len >= 0); | | should be > 0 as well. Sent patch v3. Thank you. -- Prasad J Pandit / Red Hat Pro

Re: [Qemu-devel] [PATCH v2] lsi53c895a: check message length value is valid

2018-10-30 Thread Paolo Bonzini
On 30/10/2018 07:28, P J P wrote: > From: Prasad J Pandit > > While writing a message in 'lsi_do_msgin', message length value > in 'msg_len' could be invalid. Add check to avoid OOB access issue. > > Signed-off-by: Prasad J Pandit Reviewed-by: Paolo Bonzini with one change below: > --- > h

[Qemu-devel] [PATCH v2] lsi53c895a: check message length value is valid

2018-10-29 Thread P J P
From: Prasad J Pandit While writing a message in 'lsi_do_msgin', message length value in 'msg_len' could be invalid. Add check to avoid OOB access issue. Signed-off-by: Prasad J Pandit --- hw/scsi/lsi53c895a.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) Update v