Re: [Qemu-devel] [PATCH v2] linux-user: Add signal handling support for x86_64

2017-02-26 Thread Pranith Kumar
On Sun, Feb 26, 2017 at 7:29 AM, Laurent Vivier wrote: >> @@ -6421,11 +6597,13 @@ static void handle_pending_signal(CPUArchState >> *cpu_env, int sig, >> || defined(TARGET_NIOS2) >> /* These targets do not have traditional signals. */ >> setup_rt_frame(sig, sa, &k->inf

Re: [Qemu-devel] [PATCH v2] linux-user: Add signal handling support for x86_64

2017-02-26 Thread Laurent Vivier
Le 26/02/2017 à 13:39, Peter Maydell a écrit : > On 26 February 2017 at 12:29, Laurent Vivier wrote: >> Le 26/02/2017 à 00:04, Pranith Kumar a écrit : >>> Note that x86_64 has only _rt signal handlers. This implementation >>> attempts to share code with the x86_32 implementation. > >>> +struc

Re: [Qemu-devel] [PATCH v2] linux-user: Add signal handling support for x86_64

2017-02-26 Thread Peter Maydell
On 26 February 2017 at 12:29, Laurent Vivier wrote: > Le 26/02/2017 à 00:04, Pranith Kumar a écrit : >> Note that x86_64 has only _rt signal handlers. This implementation >> attempts to share code with the x86_32 implementation. >> +struct target_fpreg st[8]; > > Why don't you keep the origin

Re: [Qemu-devel] [PATCH v2] linux-user: Add signal handling support for x86_64

2017-02-26 Thread Laurent Vivier
Le 26/02/2017 à 00:04, Pranith Kumar a écrit : > Note that x86_64 has only _rt signal handlers. This implementation > attempts to share code with the x86_32 implementation. > > CC: Laurent Vivier > Signed-off-by: Allan Wirth > Reviewed-by: Peter Maydell > Signed-off-by: Pranith Kumar > --- >

[Qemu-devel] [PATCH v2] linux-user: Add signal handling support for x86_64

2017-02-25 Thread Pranith Kumar
Note that x86_64 has only _rt signal handlers. This implementation attempts to share code with the x86_32 implementation. CC: Laurent Vivier Signed-off-by: Allan Wirth Reviewed-by: Peter Maydell Signed-off-by: Pranith Kumar --- v2: Update with review comments from Laurent Vivier --- linux-us