Re: [Qemu-devel] [PATCH v2] i386: Allow cpuid bit override

2017-04-28 Thread Eduardo Habkost
On Tue, Apr 18, 2017 at 04:19:10PM -0500, Eric Blake wrote: > On 04/18/2017 04:01 PM, Michael Roth wrote: > > >>> @@ -3706,8 +3707,17 @@ static void x86_cpu_get_bit_prop(Object *obj, > >>> Visitor *v, const char *name, > >>> X86CPU *cpu = X86_CPU(obj); > >>> BitProperty *fp = opaque; >

Re: [Qemu-devel] [PATCH v2] i386: Allow cpuid bit override

2017-04-19 Thread Eduardo Habkost
On Tue, Apr 18, 2017 at 04:19:10PM -0500, Eric Blake wrote: > On 04/18/2017 04:01 PM, Michael Roth wrote: > >>> @@ -3706,8 +3707,17 @@ static void x86_cpu_get_bit_prop(Object *obj, > >>> Visitor *v, const char *name, > >>> X86CPU *cpu = X86_CPU(obj); > >>> BitProperty *fp = opaque; > >>>

Re: [Qemu-devel] [PATCH v2] i386: Allow cpuid bit override

2017-04-18 Thread Michael Roth
Quoting Eric Blake (2017-04-18 16:19:10) > On 04/18/2017 04:01 PM, Michael Roth wrote: > > >>> @@ -3706,8 +3707,17 @@ static void x86_cpu_get_bit_prop(Object *obj, > >>> Visitor *v, const char *name, > >>> X86CPU *cpu = X86_CPU(obj); > >>> BitProperty *fp = opaque; > >>> uint32_t f

Re: [Qemu-devel] [PATCH v2] i386: Allow cpuid bit override

2017-04-18 Thread Eric Blake
On 04/18/2017 04:01 PM, Michael Roth wrote: >>> @@ -3706,8 +3707,17 @@ static void x86_cpu_get_bit_prop(Object *obj, >>> Visitor *v, const char *name, >>> X86CPU *cpu = X86_CPU(obj); >>> BitProperty *fp = opaque; >>> uint32_t f = cpu->env.features[fp->w]; >>> +uint32_t ff = cpu

Re: [Qemu-devel] [PATCH v2] i386: Allow cpuid bit override

2017-04-18 Thread Michael Roth
Quoting Michael Roth (2017-04-18 16:01:20) > Quoting Eduardo Habkost (2017-04-13 12:36:25) > > On Tue, Mar 28, 2017 at 01:27:06PM +0200, Alexander Graf wrote: > > > KVM has a feature bitmap of CPUID bits that it knows works for guests. > > > QEMU removes bits that are not part of that bitmap automa

Re: [Qemu-devel] [PATCH v2] i386: Allow cpuid bit override

2017-04-18 Thread Michael Roth
Quoting Eduardo Habkost (2017-04-13 12:36:25) > On Tue, Mar 28, 2017 at 01:27:06PM +0200, Alexander Graf wrote: > > KVM has a feature bitmap of CPUID bits that it knows works for guests. > > QEMU removes bits that are not part of that bitmap automatically on VM > > start. > > > > However, some tim

Re: [Qemu-devel] [PATCH v2] i386: Allow cpuid bit override

2017-04-13 Thread Eduardo Habkost
On Tue, Mar 28, 2017 at 01:27:06PM +0200, Alexander Graf wrote: > KVM has a feature bitmap of CPUID bits that it knows works for guests. > QEMU removes bits that are not part of that bitmap automatically on VM > start. > > However, some times we just don't list features in that list because > they

[Qemu-devel] [PATCH v2] i386: Allow cpuid bit override

2017-03-28 Thread Alexander Graf
KVM has a feature bitmap of CPUID bits that it knows works for guests. QEMU removes bits that are not part of that bitmap automatically on VM start. However, some times we just don't list features in that list because they don't make sense for normal scenarios, but may be useful in specific, targe